GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update link of `ICU data slicer` by F3n67u · Pull Request #43483 · nodejs/node

Conversation

@F3n67u

@F3n67u F3n67u commented Jun 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

unicode-org/icu repo has renamed its default branch to main also, this pr update the link to unicode-org/icu old master branch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@F3n67u
tools: update link of ICU data slicer
d41771b
@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to Node.js internationalization support. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jun 19, 2022
lpinca
lpinca approved these changes Jun 19, 2022
View reviewed changes
@F3n67u F3n67u added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 19, 2022
@github-actions

github-actions Bot commented Jun 19, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @F3n67u. Please 👍 to approve.
F3n67u, aduh95, and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jun 19, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Jun 19, 2022
RaisinTen
RaisinTen approved these changes Jun 20, 2022
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 20, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 20, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/43483
✔  Done loading data for nodejs/node/pull/43483
----------------------------------- PR info ------------------------------------
Title      tools: update link of `ICU data slicer` (#43483)
Author     Feng Yu  (@F3n67u)
Branch     F3n67u:doc/icu -> nodejs:main
Labels     tools, i18n-api, fast-track, author ready, icu
Commits    1
 - tools: update link of `ICU data slicer`
Committers 1
 - Feng Yu 
PR-URL: https://github.com/nodejs/node/pull/43483
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43483
Reviewed-By: Luigi Pinca 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 19 Jun 2022 03:31:58 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43483#pullrequestreview-1011475702
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43483#pullrequestreview-1011485702
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43483#pullrequestreview-1011866677
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2527557031
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 6ac55fa into nodejs:main Jun 20, 2022
@aduh95

aduh95 commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

Landed in 6ac55fa
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@F3n67u
F3n67u deleted the doc/icu branch June 20, 2022 09:25
@F3n67u

F3n67u commented Jun 20, 2022

Copy link
Copy Markdown
Contributor Author

@aduh95 Thanks for landing this pr. I have a question, why nodejs github bot says "commit queue fail"? because we have not run Jenkins CI?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Jun 20, 2022
@aduh95

aduh95 commented Jun 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The CQ refuses to land PR that make changes on the tools/icu folder that doesn't have a passing Jenkins CI, however changes that are restricted to doc-only changes don't actually require a Jenkins CI to land, according to our rules. The check is at https://github.com/nodejs/node-core-utils/blob/19ddfb64bf53b0cceab9a4a039fe74af79cdee9d/lib/pr_checker.js#L397-L426, I guess it should be updated to always ignore .md files, in the mean time this kind of PRs have to be landed manually.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@F3n67u

F3n67u commented Jun 20, 2022

Copy link
Copy Markdown
Contributor Author

The CQ refuses to land PR that make changes on the tools/icu folder that doesn't have a passing Jenkins CI, however changes that are restricted to doc-only changes don't actually require a Jenkins CI to land, according to our rules. The check is at https://github.com/nodejs/node-core-utils/blob/19ddfb64bf53b0cceab9a4a039fe74af79cdee9d/lib/pr_checker.js#L397-L426, I guess it should be updated to always ignore .md files, in the mean time this kind of PRs have to be landed manually.

Thanks for the info. I learn something from you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

FWIW the rules regarding CI requirements can be found at https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#testing-and-ci
F3n67u reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
doc: update link of ICU data slicer
d0c78d2 
PR-URL: #43483
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
v18.6.0 release proposal #43789
Merged
@F3n67u F3n67u mentioned this pull request Jul 12, 2022
feat: ignore .md files when do requiresJenkinsRun check nodejs/node-core-utils#641
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@F3n67u @targos
doc: update link of ICU data slicer
9b29dc8 
PR-URL: #43483
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
doc: update link of ICU data slicer
23ec1a8 
PR-URL: #43483
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
doc: update link of ICU data slicer
79f1519 
PR-URL: nodejs/node#43483
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. i18n-api Issues and PRs related to Node.js internationalization support. icu Issues and PRs related to the ICU dependency. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@F3n67u @nodejs-github-bot @aduh95 @lpinca @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.