GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: NodeArrayBufferAllocator delegates to v8's allocator by nornagon · Pull Request #43594 · nodejs/node

Conversation

@nornagon

@nornagon nornagon commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

This allows the buffers allocated by NodeArrayBufferAllocator to be compatible
with V8 sandboxed pointers.

This is not the complete set of changes needed for compatibility with sandboxed
pointers, but it is one necessary piece.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 27, 2022
@nornagon
src: delegate NodeArrayBufferAllocator to v8's allocator
565a52b
@nornagon
nornagon force-pushed the sandbox-compat-alloc branch from 6a29a39 to 565a52b Compare June 27, 2022 21:00
@nornagon
lint
3c0ab0e
addaleax
addaleax reviewed Jun 29, 2022
View reviewed changes
Comment thread src/node_internals.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nornagon
add explanatory comment
57a51c4
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 30, 2022
RaisinTen
RaisinTen approved these changes Jun 30, 2022
View reviewed changes
@RaisinTen

RaisinTen commented Jun 30, 2022

Copy link
Copy Markdown
Member

cc @nodejs/cpp-reviewers
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44980/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
codebytere
codebytere approved these changes Jun 30, 2022
View reviewed changes
joyeecheung
joyeecheung approved these changes Jun 30, 2022
View reviewed changes
addaleax
addaleax approved these changes Jun 30, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jul 4, 2022
CI Reliability 2022-07-04 nodejs/reliability#317
Open
23 tasks
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jul 8, 2022
@nodejs-github-bot

nodejs-github-bot commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45174/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jul 9, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 9, 2022
@nodejs-github-bot
nodejs-github-bot merged commit fb21829 into nodejs:main Jul 9, 2022
@nodejs-github-bot

nodejs-github-bot commented Jul 9, 2022

Copy link
Copy Markdown
Collaborator

Landed in fb21829
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jul 12, 2022
@nornagon @targos
src: delegate NodeArrayBufferAllocator to v8's allocator
4e6a844 
PR-URL: #43594
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Jul 12, 2022
v18.6.0 release proposal #43789
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@nornagon @targos
src: delegate NodeArrayBufferAllocator to v8's allocator
4e34634 
PR-URL: #43594
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nornagon @targos
src: delegate NodeArrayBufferAllocator to v8's allocator
b9649a4 
PR-URL: #43594
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
codebytere added a commit to electron/electron that referenced this pull request Aug 23, 2022
@codebytere
src: NodeArrayBufferAllocator delegates to v8's allocator
dcc3637 
nodejs/node#43594
codebytere added a commit to electron/electron that referenced this pull request Aug 23, 2022
@codebytere
src: NodeArrayBufferAllocator delegates to v8's allocator
01b41e7 
nodejs/node#43594
codebytere added a commit to electron/electron that referenced this pull request Aug 24, 2022
@codebytere
src: NodeArrayBufferAllocator delegates to v8's allocator
036cd06 
nodejs/node#43594
codebytere added a commit to electron/electron that referenced this pull request Aug 25, 2022
@codebytere
src: NodeArrayBufferAllocator delegates to v8's allocator
734423c 
nodejs/node#43594
@RaisinTen RaisinTen mentioned this pull request Aug 26, 2022
chore: bump node to v16.17.0 (main) electron/electron#35350
Merged
jkleinsc pushed a commit to electron/electron that referenced this pull request Aug 29, 2022
@electron-roller @codebytere
chore: bump node to v16.17.0 (main) (#35350)
d0e220c 
* chore: bump node in DEPS to v16.17.0

* chore: fixup asar patch

* lib: use null-prototype objects for property descriptors

nodejs/node#43270

* src: make SecureContext fields private

nodejs/node#43173

* crypto: remove Node.js-specific webcrypto extensions

nodejs/node#43310

* test: refactor to top-level await

nodejs/node#43500

* deps: cherry-pick two libuv fixes

nodejs/node#43950

* src: slim down env-inl.h

nodejs/node#43745

* util: add AggregateError.prototype.errors to inspect output

nodejs/node#43646

* esm: improve performance & tidy tests

nodejs/node#43784

* src: NodeArrayBufferAllocator delegates to v8's allocator

nodejs/node#43594

* chore: update patch indices

* chore: update filenames

* src: refactor IsSupportedAuthenticatedMode

nodejs/node#42368

* src: add --openssl-legacy-provider option

nodejs/node#40478

* lib,src: add source map support for global eval

nodejs/node#43428

* trace_events: trace net connect event

nodejs/node#43903

* deps: update ICU to 71.1

nodejs/node#42655

This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093

* lib: give names to promisified exists() and question()

nodejs/node#43218

* crypto: add CFRG curves to Web Crypto API

nodejs/node#42507

* src: fix memory leak for v8.serialize

nodejs/node#42695

This test does not work for Electron as they do not use V8's
ArrayBufferAllocator.

* buffer: fix atob input validation

nodejs/node#42539

* src: fix ssize_t error from nghttp2.h

nodejs/node#44393

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
@RaisinTen RaisinTen mentioned this pull request Oct 2, 2022
src: simplify toggling the buffer zero-fill flag #43537
Closed
@nornagon
nornagon deleted the sandbox-compat-alloc branch October 3, 2022 21:09
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nornagon @guangwong
src: delegate NodeArrayBufferAllocator to v8's allocator
97ab5a5 
PR-URL: nodejs/node#43594
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@electron-roller @codebytere @khalwa
chore: bump node to v16.17.0 (main) (electron#35350)
a2ca4b7 
* chore: bump node in DEPS to v16.17.0

* chore: fixup asar patch

* lib: use null-prototype objects for property descriptors

nodejs/node#43270

* src: make SecureContext fields private

nodejs/node#43173

* crypto: remove Node.js-specific webcrypto extensions

nodejs/node#43310

* test: refactor to top-level await

nodejs/node#43500

* deps: cherry-pick two libuv fixes

nodejs/node#43950

* src: slim down env-inl.h

nodejs/node#43745

* util: add AggregateError.prototype.errors to inspect output

nodejs/node#43646

* esm: improve performance & tidy tests

nodejs/node#43784

* src: NodeArrayBufferAllocator delegates to v8's allocator

nodejs/node#43594

* chore: update patch indices

* chore: update filenames

* src: refactor IsSupportedAuthenticatedMode

nodejs/node#42368

* src: add --openssl-legacy-provider option

nodejs/node#40478

* lib,src: add source map support for global eval

nodejs/node#43428

* trace_events: trace net connect event

nodejs/node#43903

* deps: update ICU to 71.1

nodejs/node#42655

This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093

* lib: give names to promisified exists() and question()

nodejs/node#43218

* crypto: add CFRG curves to Web Crypto API

nodejs/node#42507

* src: fix memory leak for v8.serialize

nodejs/node#42695

This test does not work for Electron as they do not use V8's
ArrayBufferAllocator.

* buffer: fix atob input validation

nodejs/node#42539

* src: fix ssize_t error from nghttp2.h

nodejs/node#44393

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
@syg syg mentioned this pull request Mar 27, 2024
Please stop using v8::BackingStore::Reallocate #52234
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@codebytere codebytere codebytere approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@nornagon @RaisinTen @nodejs-github-bot @addaleax @codebytere @joyeecheung @legendecas @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.