GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — events: replace NodeCustomEvent with CustomEvent by F3n67u · Pull Request #43876 · nodejs/node

Conversation

@F3n67u

@F3n67u F3n67u commented Jul 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

CustomEvent is implemented at #43514, NodeCustomEvent is the same as CustomEvent, so I replace NodeCustomEvent with CustomEvent in favor of web API. cc @daeyeon

Refs: #43514 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, daeyeon, and tonivj5 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 17, 2022
@F3n67u
F3n67u requested a review from benjamingr July 17, 2022 11:53
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 17, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 17, 2022
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45487/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@F3n67u F3n67u added the events Issues and PRs related to EventEmitter and the events module. label Jul 17, 2022
@benjamingr

benjamingr commented Jul 18, 2022

Copy link
Copy Markdown
Member

@addaleax
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Jul 19, 2022
View reviewed changes
Comment thread lib/internal/event_target.js Outdated

@addaleax addaleax Jul 19, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you keep this as class NodeCustomEvent extends CustomEvent {}, that might even be a bit nicer since it’s a way to differentiate between events coming from a user and events coming from a Node.js EventEmitter .emit() call?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@F3n67u F3n67u Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help me understand what specific usercase do we need to support? I don't understand in which scenario we would need to differentiate between events coming from a user and events coming from a Node.js EventEmitter .emit() call.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
@F3n67u @aduh95
events: replace NodeCustomEvent with CustomEvent
d0560a8
@aduh95
aduh95 force-pushed the node-custom-event branch from 4098a39 to d0560a8 Compare May 11, 2024 09:37
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 11, 2024
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59094/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit bd323b6 into nodejs:main May 11, 2024
@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

Landed in bd323b6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 12, 2024
@F3n67u @targos
events: replace NodeCustomEvent with CustomEvent
5ee6924 
PR-URL: #43876
Refs: #43514
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@F3n67u @marco-ippolito
events: replace NodeCustomEvent with CustomEvent
75dd009 
PR-URL: #43876
Refs: #43514
Reviewed-By: Anna Henningsen <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@F3n67u @soophoo
events: replace NodeCustomEvent with CustomEvent
2714746 
PR-URL: nodejs#43876
Refs: nodejs#43514
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@benjamingr benjamingr Awaiting requested review from benjamingr

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. events Issues and PRs related to EventEmitter and the events module. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@F3n67u @nodejs-github-bot @benjamingr @aduh95 @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.