GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder by joyeecheung · Pull Request #44104 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Aug 2, 2022

Copy link
Copy Markdown
Member

To improve startup performance.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joyeecheung
bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder
ef44fe7 
To improve startup performance.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45806/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Hilljackcantspell

This comment was marked as off-topic.

Sign in to view
legendecas
legendecas approved these changes Aug 3, 2022
View reviewed changes
@legendecas legendecas mentioned this pull request Aug 3, 2022
meta: add codeowner for src/node_snapshot* #44113
Merged
addaleax
addaleax approved these changes Aug 3, 2022
View reviewed changes
@F3n67u F3n67u added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 4, 2022
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 4, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 3970c7a into nodejs:main Aug 4, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2022

Copy link
Copy Markdown
Collaborator

Landed in 3970c7a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@joyeecheung @danielleadams
bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder
bd27b8b 
To improve startup performance.

PR-URL: #44104
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
v18.8.0 release proposal #44246
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@joyeecheung @ruyadorno
bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder
123b2d6 
To improve startup performance.

PR-URL: #44104
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
v18.8.0 release proposal #44353
Merged
@targos targos added the dont-land-on-v16.x label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@joyeecheung @nodejs-github-bot @Hilljackcantspell @addaleax @legendecas @targos @F3n67u @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.