GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: V8: PPC: pass a scratch register when using register_location by miladfarca · Pull Request #44115 · nodejs/node

Conversation

@miladfarca

@miladfarca miladfarca commented Aug 3, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Original commit message:

PPC: pass a scratch reg when using register_location

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
Cr-Commit-Position: refs/heads/main@{#82146}

Fixes: #44055
Refs: v8/v8@9861ce1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Milad Fa
deps: V8: PPC: pass a scratch register when using register_location
2eb7c91 
Fixes: #44055
@nodejs-github-bot

nodejs-github-bot commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Aug 3, 2022
@miladfarca miladfarca mentioned this pull request Aug 3, 2022
[v18.x]: deps: V8: PPC: pass a scratch register when using register_location #44107
Closed
gengjiawen
gengjiawen approved these changes Aug 3, 2022
View reviewed changes
@miladfarca
miladfarca requested a review from targos August 5, 2022 12:39
@miladfarca

miladfarca commented Aug 5, 2022

Copy link
Copy Markdown
Contributor Author

@richardlau would you please help review and initiate CI tests for this CL? thanks.
richardlau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 5, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 5, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2022 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45864/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4803/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Aug 5, 2022
View reviewed changes

@richardlau richardlau left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Commit message should quote the message from the upstream commit, see example in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-V8.md -- can be fixed on landing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@miladfarca

miladfarca commented Aug 5, 2022

Copy link
Copy Markdown
Contributor Author

@richardlau Thanks, I've added it to the description.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes Aug 5, 2022
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
richardlau pushed a commit that referenced this pull request Aug 5, 2022
Milad Fa @richardlau
deps: V8: cherry-pick 9861ce1deae2
90c758c 
Original commit message:

    PPC: pass a scratch reg when using register_location

    Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
    Reviewed-by: Junliang Yan <[email protected]>
    Commit-Queue: Milad Farazmand <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#82146}

Fixes: #44055
PR-URL: #44115
Refs: v8/v8@9861ce1
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau

richardlau commented Aug 5, 2022

Copy link
Copy Markdown
Member

Landed in 90c758c.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau closed this Aug 5, 2022
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
Milad Fa @danielleadams
deps: V8: cherry-pick 9861ce1deae2
6256bd5 
Original commit message:

    PPC: pass a scratch reg when using register_location

    Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
    Reviewed-by: Junliang Yan <[email protected]>
    Commit-Queue: Milad Farazmand <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#82146}

Fixes: #44055
PR-URL: #44115
Refs: v8/v8@9861ce1
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
v18.8.0 release proposal #44246
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
Milad Fa @ruyadorno
deps: V8: cherry-pick 9861ce1deae2
52a516a 
Original commit message:

    PPC: pass a scratch reg when using register_location

    Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
    Reviewed-by: Junliang Yan <[email protected]>
    Commit-Queue: Milad Farazmand <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#82146}

Fixes: #44055
PR-URL: #44115
Refs: v8/v8@9861ce1
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
v18.8.0 release proposal #44353
Merged
@targos targos added the dont-land-on-v16.x label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@targos targos Awaiting requested review from targos
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

regexp crash on ppc64le

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miladfarca @nodejs-github-bot @richardlau @gengjiawen @mhdawson @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.