GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bootstrap: check more metadata when loading the snapshot by joyeecheung · Pull Request #44132 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Aug 4, 2022

Copy link
Copy Markdown
Member

This patch stores the metadata about the Node.js binary
into the SnapshotData and adds fields denoting how the
snapshot was generated, on what platform it was
generated as well as the V8 cached data version flag.
Instead of simply crashing when the metadata doesn't
match, Node.js now prints an error message and exit with
1 for the customized snapshot, or ignore the snapshot
and start from scratch if it's the default one.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 4, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45838/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Aug 4, 2022
View reviewed changes
@joyeecheung

joyeecheung commented Aug 4, 2022

Copy link
Copy Markdown
Member Author

Oops, forgot to commit the tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45840/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 5, 2022
CI Reliability 2022-08-05 nodejs/reliability#337
Open
17 tasks
legendecas
legendecas approved these changes Aug 5, 2022
View reviewed changes
joyeecheung
joyeecheung commented Aug 5, 2022
View reviewed changes
Comment thread src/node.cc Outdated

@joyeecheung joyeecheung Aug 5, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a bug for cross-compiled binaries.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45863/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 6, 2022
CI Reliability 2022-08-06 nodejs/reliability#338
Open
CI Reliability 2022-08-07 nodejs/reliability#339
Open
CI Reliability 2022-08-08 nodejs/reliability#340
Open
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45918/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung added 4 commits August 9, 2022 02:42
@joyeecheung
bootstrap: check more metadata when loading the snapshot
e65d693 
This patch stores the metadata about the Node.js binary
into the SnapshotData and adds fields denoting how the
snapshot was generated, on what platform it was
generated as well as the V8 cached data version flag.
Instead of simply crashing when the metadata doesn't
match, Node.js now prints an error message and exit with
1 for the customized snapshot, or ignore the snapshot
and start from scratch if it's the default one.
@joyeecheung
fixup! bootstrap: check more metadata when loading the snapshot
3b83287
@joyeecheung
fixup! fixup! bootstrap: check more metadata when loading the snapshot
6f4a5e7
@joyeecheung
fixup! fixup! fixup! bootstrap: check more metadata when loading the …
76ec477 
…snapshot
@joyeecheung
joyeecheung force-pushed the snapshot-metadata branch from f7fb91e to 76ec477 Compare August 8, 2022 18:47
@joyeecheung

joyeecheung commented Aug 8, 2022

Copy link
Copy Markdown
Member Author

Rebased to resolve conflict with #44121
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45932/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung added the snapshot Issues and PRs related to the startup snapshot. label Aug 8, 2022
@github-actions github-actions Bot mentioned this pull request Aug 9, 2022
CI Reliability 2022-08-09 nodejs/reliability#341
Open
8 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45943/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Aug 9, 2022
View reviewed changes
@joyeecheung joyeecheung added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 9, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 9, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 5291096 into nodejs:main Aug 9, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2022

Copy link
Copy Markdown
Collaborator

Landed in 5291096
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 10, 2022
CI Reliability 2022-08-10 nodejs/reliability#342
Open
7 tasks
@legendecas legendecas mentioned this pull request Aug 10, 2022
src: iterate over base objects to prepare for snapshot #44192
Merged
This was referenced Aug 11, 2022
CI Reliability 2022-08-11 nodejs/reliability#343
Open
CI Reliability 2022-08-12 nodejs/reliability#344
Open
CI Reliability 2022-08-13 nodejs/reliability#345
Open
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@joyeecheung @danielleadams
bootstrap: check more metadata when loading the snapshot
98fa488 
This patch stores the metadata about the Node.js binary
into the SnapshotData and adds fields denoting how the
snapshot was generated, on what platform it was
generated as well as the V8 cached data version flag.
Instead of simply crashing when the metadata doesn't
match, Node.js now prints an error message and exit with
1 for the customized snapshot, or ignore the snapshot
and start from scratch if it's the default one.

PR-URL: #44132
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
v18.8.0 release proposal #44246
Closed
@ruyadorno ruyadorno added the backport-requested-v18.x label Aug 22, 2022
@ruyadorno

ruyadorno commented Aug 22, 2022

Copy link
Copy Markdown
Member

hi @joyeecheung, unfortunately 5291096 is not landing cleanly in the updated v18.x-staging branch.

This PR will need to be backported in order to land in a v18.x release 😊
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung mentioned this pull request Aug 25, 2022
src: fix cppgc incompatibility in v8 #43521
Closed
joyeecheung added a commit to joyeecheung/node that referenced this pull request Aug 25, 2022
@joyeecheung
bootstrap: check more metadata when loading the snapshot
9cdbf6b 
This patch stores the metadata about the Node.js binary
into the SnapshotData and adds fields denoting how the
snapshot was generated, on what platform it was
generated as well as the V8 cached data version flag.
Instead of simply crashing when the metadata doesn't
match, Node.js now prints an error message and exit with
1 for the customized snapshot, or ignore the snapshot
and start from scratch if it's the default one.

PR-URL: nodejs#44132
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@joyeecheung

joyeecheung commented Aug 25, 2022

Copy link
Copy Markdown
Member Author

This depends on #44121, so needs to be backported after #44358
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol

juanarbol commented Oct 2, 2022

Copy link
Copy Markdown
Member

hi @joyeecheung, unfortunately 5291096 is not landing cleanly in the updated v18.x-staging branch.

This PR will need to be backported in order to land in a v18.x release blush

Same thing for the v16.x branch
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol added the backport-requested-v16.x label Oct 2, 2022
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged
@joyeecheung joyeecheung mentioned this pull request Oct 14, 2022
src: consolidate exit codes in the code base #44746
Merged
joyeecheung added a commit to joyeecheung/node that referenced this pull request Oct 14, 2022
@joyeecheung
bootstrap: check more metadata when loading the snapshot
7847629 
This patch stores the metadata about the Node.js binary
into the SnapshotData and adds fields denoting how the
snapshot was generated, on what platform it was
generated as well as the V8 cached data version flag.
Instead of simply crashing when the metadata doesn't
match, Node.js now prints an error message and exit with
1 for the customized snapshot, or ignore the snapshot
and start from scratch if it's the default one.

PR-URL: nodejs#44132
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Oct 14, 2022
[v18.x] backport various patches of internal refactorings for snapshot and realms #45007
Closed
joyeecheung added a commit that referenced this pull request Nov 1, 2022
@joyeecheung
bootstrap: check more metadata when loading the snapshot
c0b7cdb 
This patch stores the metadata about the Node.js binary
into the SnapshotData and adds fields denoting how the
snapshot was generated, on what platform it was
generated as well as the V8 cached data version flag.
Instead of simply crashing when the metadata doesn't
match, Node.js now prints an error message and exit with
1 for the customized snapshot, or ignore the snapshot
and start from scratch if it's the default one.

PR-URL: #44132
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
juanarbol pushed a commit that referenced this pull request Nov 4, 2022
@joyeecheung @juanarbol
bootstrap: check more metadata when loading the snapshot
4e1c200 
This patch stores the metadata about the Node.js binary
into the SnapshotData and adds fields denoting how the
snapshot was generated, on what platform it was
generated as well as the V8 cached data version flag.
Instead of simply crashing when the metadata doesn't
match, Node.js now prints an error message and exit with
1 for the customized snapshot, or ignore the snapshot
and start from scratch if it's the default one.

PR-URL: #44132
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@joyeecheung @danielleadams
bootstrap: check more metadata when loading the snapshot
e638ea4 
This patch stores the metadata about the Node.js binary
into the SnapshotData and adds fields denoting how the
snapshot was generated, on what platform it was
generated as well as the V8 cached data version flag.
Instead of simply crashing when the metadata doesn't
match, Node.js now prints an error message and exit with
1 for the customized snapshot, or ignore the snapshot
and start from scratch if it's the default one.

PR-URL: #44132
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. snapshot Issues and PRs related to the startup snapshot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@joyeecheung @nodejs-github-bot @ruyadorno @juanarbol @addaleax @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.