GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: improve view validation on `ReadableStreamBYOBRequest.respondWithNewView()` by daeyeon · Pull Request #44155 · nodejs/node

Conversation

@daeyeon

@daeyeon daeyeon commented Aug 6, 2022

Copy link
Copy Markdown
Member

  • This throws if the view is zero-length when there is an active reader when using ReadableStreamBYOBRequest.respondWithNewView().

  • By doing that, we can get all tests passed in wpt/streams/readable-byte-streams/bad-buffers-and-views.any.js.

Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view

  1. If state is "closed"
    5.1. If view.[[ByteLength]] is not 0, throw a TypeError exception.
  2. Otherwise,
    6.1 Assert: state is "readable".
    6.2 If view.[[ByteLength]] is 0, throw a TypeError exception.

Signed-off-by: Daeyeon Jeong [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 6, 2022
@daeyeon daeyeon changed the title stream: improve views validation on ReadableStreamBYOBRequest stream: improve view validation on ReadableStreamBYOBRequest.respondWithNewView() Aug 6, 2022
lpinca
lpinca approved these changes Aug 6, 2022
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 6, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45886/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 7, 2022
CI Reliability 2022-08-07 nodejs/reliability#339
Open
13 tasks
@daeyeon daeyeon added web streams Issues and PRs related to the Web Streams API. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 7, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45897/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daeyeon daeyeon added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 7, 2022
@github-actions github-actions Bot mentioned this pull request Aug 8, 2022
CI Reliability 2022-08-08 nodejs/reliability#340
Open
11 tasks
@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 8, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 8, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45909/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 9, 2022
CI Reliability 2022-08-09 nodejs/reliability#341
Open
CI Reliability 2022-08-10 nodejs/reliability#342
Open
CI Reliability 2022-08-11 nodejs/reliability#343
Open
@daeyeon
stream: improve views validation on BYOBRequest
ee3507e 
- This throws if the view is zero-length when there is an active reader
when using `ReadableStreamBYOBRequest.respondWithNewView()`.

- By doing that, we can get all tests passed in
`readable-byte-streams/bad-buffers-and-views.any.js`.

Signed-off-by: Daeyeon Jeong [email protected]
@daeyeon
daeyeon force-pushed the main.webstream-220806.Sat.5609 branch from d2b1fd7 to ee3507e Compare August 11, 2022 01:13
@daeyeon

daeyeon commented Aug 11, 2022

Copy link
Copy Markdown
Member Author

Rebased since test/wpt/status/streams.json is updated in #43455.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 11, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45991/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 15, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 15, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44155
✔  Done loading data for nodejs/node/pull/44155
----------------------------------- PR info ------------------------------------
Title      stream: improve view validation on `ReadableStreamBYOBRequest.respondWithNewView()` (#44155)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     daeyeon:main.webstream-220806.Sat.5609 -> nodejs:main
Labels     author ready, needs-ci, web streams
Commits    1
 - stream: improve views validation on `BYOBRequest`
Committers 1
 - Daeyeon Jeong 
PR-URL: https://github.com/nodejs/node/pull/44155
Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44155
Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - stream: improve views validation on `BYOBRequest`
   ℹ  This PR was created on Sat, 06 Aug 2022 17:16:39 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44155#pullrequestreview-1064334855
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-08-11T01:31:42Z: https://ci.nodejs.org/job/node-test-pull-request/45991/
- Querying data for job/node-test-pull-request/45991/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2862673144
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Aug 15, 2022
View reviewed changes
@lpinca lpinca added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 15, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 46f6d22 into nodejs:main Aug 15, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2022

Copy link
Copy Markdown
Collaborator

Landed in 46f6d22
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daeyeon
daeyeon deleted the main.webstream-220806.Sat.5609 branch August 15, 2022 23:58
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@daeyeon @danielleadams
stream: improve views validation on BYOBRequest
96c3373 
- This throws if the view is zero-length when there is an active reader
when using `ReadableStreamBYOBRequest.respondWithNewView()`.

- By doing that, we can get all tests passed in
`readable-byte-streams/bad-buffers-and-views.any.js`.

Signed-off-by: Daeyeon Jeong [email protected]
PR-URL: #44155
Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
v18.8.0 release proposal #44246
Closed
@daeyeon daeyeon mentioned this pull request Aug 16, 2022
test: update Web Streams WPT #44234
Merged
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@daeyeon @ruyadorno
stream: improve views validation on BYOBRequest
c079abe 
- This throws if the view is zero-length when there is an active reader
when using `ReadableStreamBYOBRequest.respondWithNewView()`.

- By doing that, we can get all tests passed in
`readable-byte-streams/bad-buffers-and-views.any.js`.

Signed-off-by: Daeyeon Jeong [email protected]
PR-URL: #44155
Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
v18.8.0 release proposal #44353
Merged
@juanarbol

juanarbol commented Oct 3, 2022

Copy link
Copy Markdown
Member

Depends on #43455
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol added the backport-blocked-v16.x label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@daeyeon @nodejs-github-bot @juanarbol @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.