GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: update wpt url status by cola119 · Pull Request #44175 · nodejs/node

Conversation

@cola119

@cola119 cola119 commented Aug 8, 2022

Copy link
Copy Markdown
Member

urlencoded-parser.any.js is now passed thanks to nodejs/undici#1563, which is released in undici v5.8.1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@cola119
test: update wpt url status
11e787a
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 8, 2022
@cola119
cola119 marked this pull request as ready for review August 8, 2022 14:32
targos
targos approved these changes Aug 8, 2022
View reviewed changes
aduh95
aduh95 approved these changes Aug 8, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 8, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 8, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45924/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
F3n67u
F3n67u approved these changes Aug 8, 2022
View reviewed changes
lpinca
lpinca approved these changes Aug 8, 2022
View reviewed changes
@F3n67u F3n67u added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 10, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44175
✔  Done loading data for nodejs/node/pull/44175
----------------------------------- PR info ------------------------------------
Title      test: update wpt url status (#44175)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     cola119:update-url-status -> nodejs:main
Labels     test, author ready, needs-ci
Commits    1
 - test: update wpt url status
Committers 1
 - cola119 
PR-URL: https://github.com/nodejs/node/pull/44175
Reviewed-By: Michaël Zasso 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Feng Yu 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44175
Reviewed-By: Michaël Zasso 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Feng Yu 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 08 Aug 2022 14:31:25 GMT
   ✔  Approvals: 4
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065324586
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065342638
   ✔  - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065381517
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44175#pullrequestreview-1065631496
   ✖  This PR needs to wait 8 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-08-08T15:11:35Z: https://ci.nodejs.org/job/node-test-pull-request/45924/
- Querying data for job/node-test-pull-request/45924/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2830437356
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 10, 2022
@github-actions

github-actions Bot commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.
F3n67u reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@F3n67u F3n67u added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 10, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 3028af9 into nodejs:main Aug 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2022

Copy link
Copy Markdown
Collaborator

Landed in 3028af9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@cola119 @danielleadams
test: update wpt url status
7104210 
PR-URL: #44175
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
v18.8.0 release proposal #44246
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@cola119 @ruyadorno
test: update wpt url status
b2a15b6 
PR-URL: #44175
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
v18.8.0 release proposal #44353
Merged
@juanarbol juanarbol added the dont-land-on-v16.x label Oct 3, 2022
@juanarbol

juanarbol commented Oct 3, 2022

Copy link
Copy Markdown
Member

This causes jstests to fail:

Error: Found 1 unexpected failures. Consider updating test/wpt/status/url.json for these files:
urlencoded-parser.any.js
    at process.<anonymous> (/home/juanarbol/GitHub/node/test/common/wpt.js:496:15)
    at process.emit (node:events:525:35)
Command: out/Release/node /home/juanarbol/GitHub/node/test/wpt/test-url.js
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes
+2 more reviewers
@targos targos targos approved these changes
@F3n67u F3n67u F3n67u approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@cola119 @nodejs-github-bot @juanarbol @lpinca @targos @F3n67u @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.