GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bootstrap: fixup Error.stackTraceLimit for user-land snapshot by joyeecheung · Pull Request #44203 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Aug 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It's difficult for V8 to handle Error.stackTraceLimit in the snapshot,
so delete it from the Error constructor if it's present before
snapshot serialization, and re-install it after deserialization.
In addition try not to touch it from our internals during snapshot
building in the first place by updating
isErrorStackTraceLimitWritable().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joyeecheung
bootstrap: fixup Error.stackTraceLimit for user-land snapshot
d78a717 
It's difficult for V8 to handle Error.stackTraceLimit in the snapshot,
so delete it from the Error constructor if it's present before
snapshot serialization, and re-install it after deserialization.
In addition try not to touch it from our internals during snapshot
building in the first place by updating
isErrorStackTraceLimitWritable().
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run. labels Aug 10, 2022
@joyeecheung

joyeecheung commented Aug 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

After looking into https://chromium-review.googlesource.com/c/v8/v8/+/3319481 I think that it makes more sense for us to clean it up - there are several constraints in the SnapshotCreator that don't exist from the embedder's side so it's just much simpler to handle this in Node.js. It should be a rare case that only shows up when users actually try to mutate Error.stackTraceLimit themselves in the snapshot script anyway.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Aug 11, 2022
View reviewed changes
Comment thread lib/internal/main/mksnapshot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung @aduh95
fixup! bootstrap: fixup Error.stackTraceLimit for user-land snapshot
6df1fae 
Co-authored-by: Antoine du Hamel <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Aug 11, 2022
src: support WeakReference, diagnostics_channel and net in the snapshot #44193
Closed
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45992/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas reviewed Aug 11, 2022
View reviewed changes
Comment thread lib/internal/v8/startup_snapshot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung
fixup! fixup! bootstrap: fixup Error.stackTraceLimit for user-land sn…
86dfc54 
…apshot
legendecas
legendecas approved these changes Aug 11, 2022
View reviewed changes

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45994/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung mentioned this pull request Aug 15, 2022
Snapshot test failures nodejs/node-v8#237
Closed
@joyeecheung joyeecheung added the review wanted PRs that need review. label Aug 15, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46049/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Aug 17, 2022
View reviewed changes
Comment thread lib/internal/main/mksnapshot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/main/mksnapshot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/main/mksnapshot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung @aduh95
fixup! bootstrap: fixup Error.stackTraceLimit for user-land snapshot
082f665 
Co-authored-by: Antoine du Hamel <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46053/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Aug 17, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46055/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung removed the review wanted PRs that need review. label Aug 17, 2022
@github-actions github-actions Bot mentioned this pull request Aug 18, 2022
CI Reliability 2022-08-18 nodejs/reliability#350
Open
8 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46058/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 18, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 18, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 4f1a9fc into nodejs:main Aug 18, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4f1a9fc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 19, 2022
CI Reliability 2022-08-19 nodejs/reliability#351
Open
CI Reliability 2022-08-20 nodejs/reliability#352
Open
This was referenced Aug 21, 2022
CI Reliability 2022-08-21 nodejs/reliability#353
Open
CI Reliability 2022-08-22 nodejs/reliability#354
Open
@ruyadorno ruyadorno added the backport-blocked-v18.x label Aug 22, 2022
@ruyadorno

This comment was marked as resolved.

Sign in to view
@ruyadorno ruyadorno mentioned this pull request Aug 22, 2022
bootstrap: implement run-time user-land snapshots via --build-snapshot and --snapshot-blob #38905
Closed
@ruyadorno ruyadorno removed the backport-blocked-v18.x label Aug 23, 2022
@ruyadorno

ruyadorno commented Aug 23, 2022

Copy link
Copy Markdown
Member

I managed to land #38905 and retried this one which did land cleanly this time, as such I'm removing the bakcport-blocked-v18.x label 😊
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@joyeecheung @ruyadorno
bootstrap: fixup Error.stackTraceLimit for user-land snapshot
87d7845 
It's difficult for V8 to handle Error.stackTraceLimit in the snapshot,
so delete it from the Error constructor if it's present before
snapshot serialization, and re-install it after deserialization.
In addition try not to touch it from our internals during snapshot
building in the first place by updating
isErrorStackTraceLimitWritable().

PR-URL: #44203
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
v18.8.0 release proposal #44353
Merged
@juanarbol

juanarbol commented Sep 30, 2022

Copy link
Copy Markdown
Member

Looks like this depends on #38905; the v16.x branch is presenting some issues w/ this PR; I will mark this as the presumptuous dependency. Feel free to remove the label if I'm wrong.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol added the dont-land-on-v16.x label Sep 30, 2022
This was referenced Sep 24, 2024
Error.stackTraceLimit becomes undefined when running from snapshot #55100
Closed
Tracking issue: support of builtins and V8 issues in run-time user-land snapshots #44014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@joyeecheung @nodejs-github-bot @ruyadorno @juanarbol @legendecas @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.