GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x] src: split property helpers from node::Environment by legendecas · Pull Request #44251 · nodejs/node

Conversation

@legendecas

@legendecas legendecas commented Aug 16, 2022

Copy link
Copy Markdown
Member

PR-URL: #44056
Refs: #42528
Reviewed-By: Ben Noordhuis [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Feng Yu [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/modules
  • @nodejs/net
  • @nodejs/startup
  • @nodejs/vm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v18.x labels Aug 16, 2022
@legendecas

legendecas commented Aug 16, 2022

Copy link
Copy Markdown
Member Author

/cc @danielleadams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas

legendecas commented Aug 16, 2022

Copy link
Copy Markdown
Member Author

The file that linter is complaining about is not changed in this PR. I'll leave it to releasers to determine what to do with the staging branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams
danielleadams force-pushed the v18.x-staging branch from 96c3373 to e028edb Compare August 17, 2022 01:16
@danielleadams

danielleadams commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

Hi @legendecas - I had to update v18.x-staging, so this will need a rebase
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
src: split property helpers from node::Environment
aed3566 
PR-URL: nodejs#44056
Refs: nodejs#42528
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
@legendecas
legendecas force-pushed the backport-44056-to-18 branch from b956ac4 to aed3566 Compare August 17, 2022 13:02
@legendecas

legendecas commented Aug 17, 2022

Copy link
Copy Markdown
Member Author

@danielleadams rebased.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno
ruyadorno approved these changes Aug 21, 2022
View reviewed changes
@ruyadorno

ruyadorno commented Aug 21, 2022

Copy link
Copy Markdown
Member

Landed in 68ee8e9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno closed this Aug 21, 2022
ruyadorno pushed a commit that referenced this pull request Aug 21, 2022
@legendecas @ruyadorno
src: split property helpers from node::Environment
68ee8e9 
PR-URL: #44056
Backport-PR-URL: #44251
Refs: #42528
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
@legendecas
legendecas deleted the backport-44056-to-18 branch August 22, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@legendecas @nodejs-github-bot @danielleadams @ruyadorno
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.