GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: remove v8abbr.h by tniessen · Pull Request #44402 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Aug 25, 2022

Copy link
Copy Markdown
Member

As far as I can tell, the definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed.

Refs: #43652

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen
tniessen requested review from bnoordhuis and joyeecheung August 25, 2022 21:07
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Aug 25, 2022
joyeecheung
joyeecheung approved these changes Aug 26, 2022
View reviewed changes
addaleax
addaleax approved these changes Aug 26, 2022
View reviewed changes
gengjiawen
gengjiawen approved these changes Aug 26, 2022
View reviewed changes
@tniessen
src: remove v8abbr.h
78cefeb 
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: nodejs#43652
@tniessen
tniessen force-pushed the src-remove-v8abbr branch from 40bc0a2 to 78cefeb Compare August 26, 2022 10:24
@tniessen

tniessen commented Aug 26, 2022

Copy link
Copy Markdown
Member Author

Pacified format-cpp.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes Aug 26, 2022
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this as a todo so thank you for taking it off my plate, Tobias. :-)

As an aside: I don't think it's always correct to read the second field from ExternalString because that's a cached data pointer (i.e., can be nullptr) but since no one's complained so far...

(The first field points to the Canonical Source of Truth but decoding the pointee is involved.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tniessen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen tniessen added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 26, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 26, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Aug 27, 2022
CI Reliability 2022-08-27 nodejs/reliability#359
Open
CI Reliability 2022-08-28 nodejs/reliability#360
Open
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46286/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Aug 28, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Aug 29, 2022
CI Reliability 2022-08-29 nodejs/reliability#361
Open
30 tasks
RaisinTen
RaisinTen approved these changes Aug 29, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Aug 30, 2022
CI Reliability 2022-08-30 nodejs/reliability#362
Open
27 tasks
@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 30, 2022
@nodejs-github-bot
nodejs-github-bot merged commit ad41c91 into nodejs:main Aug 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 30, 2022

Copy link
Copy Markdown
Collaborator

Landed in ad41c91
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Aug 31, 2022
CI Reliability 2022-08-31 nodejs/reliability#363
Open
CI Reliability 2022-09-01 nodejs/reliability#364
Open
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
@tniessen @RafaelGSS
src: remove v8abbr.h
24344ce 
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: #43652
PR-URL: #44402
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 5, 2022
v18.9.0 release proposal #44521
Merged
@RafaelGSS RafaelGSS added dont-land-on-v14.x labels Sep 6, 2022
@RafaelGSS

RafaelGSS commented Sep 6, 2022

Copy link
Copy Markdown
Member

Adding dont-land labels because this PR depends on a semver-major change #43652
MoLow, ruyadorno, and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow pushed a commit to MoLow/node that referenced this pull request Sep 7, 2022
@tniessen @MoLow
src: remove v8abbr.h
2ea7dcb 
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: nodejs#43652
PR-URL: nodejs#44402
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Sep 8, 2022
[v18.x backport] src: add detailed embedder process initialization API #44358
Closed
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@tniessen @nodejs-github-bot @RafaelGSS @bnoordhuis @jasnell @addaleax @gengjiawen @joyeecheung @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.