GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update zlib to upstream 926ac23 by RafaelGSS · Pull Request #44412 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Aug 26, 2022

Copy link
Copy Markdown
Member

Updated as described in doc/contributing/maintaining-zlib.md.

Attempt to solve: nodejs/security-wg#824

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, baparham, Fix91, and jaredmcateer reacted with thumbs up emoji
All reactions
  • 👍 4 reactions
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib module and its compression dependencies. labels Aug 26, 2022
jasnell
jasnell approved these changes Aug 28, 2022
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was referenced Aug 29, 2022
CVE-2022-37434 zlib vulnerability nodejs/security-wg#824
Closed
CVE-2022-37434 (zlib) found on main nodejs/nodejs-dependency-vuln-assessments#50
Closed
@targos

targos commented Aug 29, 2022

Copy link
Copy Markdown
Member

As I said in #44254 (comment), we have to adapt zlib.gyp somehow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS

RafaelGSS commented Aug 29, 2022

Copy link
Copy Markdown
Member Author

As I said in #44254 (comment), we have to adapt zlib.gyp somehow.

Yeah, I'll try to work on it this week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 2, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46392/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 3, 2022
CI Reliability 2022-09-03 nodejs/reliability#366
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 3, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46404/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 4, 2022
CI Reliability 2022-09-04 nodejs/reliability#367
Open
24 tasks
@RaisinTen RaisinTen added the needs-benchmark-ci PRs that need a benchmark CI run. label Sep 4, 2022
This was referenced Sep 5, 2022
CI Reliability 2022-09-05 nodejs/reliability#368
Open
CI Reliability 2022-09-06 nodejs/reliability#369
Open
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 6, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46430/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46448/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46456/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 7, 2022
CI Reliability 2022-09-07 nodejs/reliability#370
Open
15 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46458/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Sep 7, 2022

Copy link
Copy Markdown
Member

Don't we need ab587ca anymore?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS

RafaelGSS commented Sep 7, 2022

Copy link
Copy Markdown
Member Author

Don't we need ab587ca anymore?

fill_window_sse.c was removed. The chunkcopy still exists but the failing test doesn't seem related to this file.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Sep 7, 2022

Copy link
Copy Markdown
Member

It's not related to the failing test. This commit fixed #35629
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 8, 2022
CI Reliability 2022-09-08 nodejs/reliability#371
Open
12 tasks
@RafaelGSS

RafaelGSS commented Sep 8, 2022

Copy link
Copy Markdown
Member Author

I'll trigger the build again just to see if I get a different build output. The last ones don't show anything relevant to me. I've set up a Windows x64 machine to see if I can reproduce this behaviour, but didn't work (it's building without issues).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2022
@github-actions github-actions Bot mentioned this pull request Oct 30, 2022
CI Reliability 2022-10-30 nodejs/reliability#415
Open
15 tasks
RaisinTen
RaisinTen reviewed Oct 30, 2022
View reviewed changes
Comment thread deps/zlib/zlib.gyp
'adler32.c',
'compress.c',
'contrib/optimizations/insert_string.h',
'cpu_features.c',

@RaisinTen RaisinTen Oct 30, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are adding cpu_features.c to sources here already, is there any need to re-add it to the sources below? I guess we could treat the cpu_features.h file too in the same way.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@RafaelGSS RafaelGSS Oct 31, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense. Look afb64b0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot mentioned this pull request Oct 31, 2022
CI Reliability 2022-10-31 nodejs/reliability#416
Open
19 tasks
@RafaelGSS
deps: include cpu_features.h to root sources
afb64b0
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 31, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 31, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47597/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes Oct 31, 2022
View reviewed changes

@RaisinTen RaisinTen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot mentioned this pull request Nov 1, 2022
CI Reliability 2022-11-01 nodejs/reliability#417
Open
17 tasks
@lpinca lpinca mentioned this pull request Nov 1, 2022
Memory corruption and crash when streaming to zlib #45268
Closed
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47625/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 2, 2022
CI Reliability 2022-11-02 nodejs/reliability#418
Open
CI Reliability 2022-11-05 nodejs/reliability#419
Open
@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47719/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47731/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47747/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 7, 2022
CI Reliability 2022-11-07 nodejs/reliability#421
Open
18 tasks
@baparham

baparham commented Nov 7, 2022

Copy link
Copy Markdown

FWIW upstream (chromium zlib fork) just landed the update to canonical zlib 1.2.13 in https://chromium.googlesource.com/chromium/src/+/e2e230364bcf8fe55dde5dca8310da6906ae64ad

Since this isn't merged in yet, it would make sense to push for upgrading Node.js to this latest version. Or does it make more sense to do it in two stages?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 8, 2022
CI Reliability 2022-11-08 nodejs/reliability#422
Open
CI Reliability 2022-11-09 nodejs/reliability#423
Open
@nodejs-github-bot

nodejs-github-bot commented Nov 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47801/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS

RafaelGSS commented Nov 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

FWIW upstream (chromium zlib fork) just landed the update to canonical zlib 1.2.13 in https://chromium.googlesource.com/chromium/src/+/e2e230364bcf8fe55dde5dca8310da6906ae64ad

Since this isn't merged in yet, it would make sense to push for upgrading Node.js to this latest version. Or does it make more sense to do it in two stages?

I prefer to do it in two stages, considering the fact this PR changes the .gyp files.

FWIW All the CI failures are non-related to the PR (no space left, windows race condition bug , and so forth)
mhdawson reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca mentioned this pull request Nov 9, 2022
deps: update zlib to upstream 8bbd6c31 #45387
Closed
@lpinca

lpinca commented Nov 9, 2022

Copy link
Copy Markdown
Member

I've opened #45387 for a direct update to upstream 8bbd6c31.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS

RafaelGSS commented Nov 9, 2022

Copy link
Copy Markdown
Member Author

Closing in favor of #45387
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS closed this Nov 9, 2022
This was referenced Nov 10, 2022
CI Reliability 2022-11-10 nodejs/reliability#424
Open
CI Reliability 2022-11-11 nodejs/reliability#425
Open
CI Reliability 2022-11-12 nodejs/reliability#426
Open
CI Reliability 2022-11-13 nodejs/reliability#427
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
@targos targos Awaiting requested review from targos
+2 more reviewers
@p-b-o p-b-o p-b-o left review comments
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies. needs-benchmark-ci PRs that need a benchmark CI run. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@RafaelGSS @targos @nodejs-github-bot @baparham @Neustradamus @richardlau @p-b-o @niyas-sait @RaisinTen @lpinca @jasnell @mhdawson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.