GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: fix duration_ms to be milliseconds by MoLow · Pull Request #44490 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Sep 2, 2022 •
edited by cclauss
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I figured if we land #44450 (merged) it will be best to also fix it here.
this fix depends on nodejs/tap2junit#38 (merged)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory. labels Sep 2, 2022
@MoLow
MoLow force-pushed the fix-duration-ms branch from af07b24 to bc76d98 Compare September 2, 2022 07:44
@mscdex mscdex changed the title fix duration_ms to be milliseconds tools: fix duration_ms to be milliseconds Sep 2, 2022
@MoLow MoLow added the review wanted PRs that need review. label Sep 4, 2022
@MoLow
MoLow force-pushed the fix-duration-ms branch from bef9eb6 to d32e6ad Compare September 5, 2022 14:01
@MoLow

MoLow commented Sep 5, 2022

Copy link
Copy Markdown
Member Author

@cclauss can you take a look at this and at nodejs/tap2junit#38 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cclauss
cclauss requested review from Trott, benjamingr and cjihrig September 5, 2022 14:27
benjamingr
benjamingr approved these changes Sep 5, 2022
View reviewed changes
@MoLow
MoLow requested a review from aduh95 September 5, 2022 14:56
aduh95
aduh95 reviewed Sep 6, 2022
View reviewed changes
Comment thread tools/test.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
himself65
himself65 approved these changes Sep 6, 2022
View reviewed changes
aduh95
aduh95 approved these changes Sep 6, 2022
View reviewed changes
@targos targos added blocked PRs that are blocked by other issues or PRs. lts-watch-v14.x labels Sep 6, 2022
@MoLow MoLow removed the review wanted PRs that need review. label Sep 11, 2022
juanarbol
juanarbol approved these changes Oct 27, 2022
View reviewed changes
@juanarbol juanarbol removed the blocked PRs that are blocked by other issues or PRs. label Oct 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47510/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47513/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow

MoLow commented Oct 28, 2022

Copy link
Copy Markdown
Member Author

@juanarbol AFAIK this is still blocked due to nodejs/tap2junit#41
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the blocked PRs that are blocked by other issues or PRs. label Oct 28, 2022
This was referenced Oct 29, 2022
CI Reliability 2022-10-29 nodejs/reliability#414
Open
CI Reliability 2022-10-30 nodejs/reliability#415
Open
CI Reliability 2022-10-31 nodejs/reliability#416
Open
CI Reliability 2022-11-01 nodejs/reliability#417
Open
jasnell
jasnell approved these changes Nov 2, 2022
View reviewed changes
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
@MoLow MoLow removed the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2023
@MoLow
tools: fix duration_ms to be milliseconds
45ff7ae
@MoLow
MoLow force-pushed the fix-duration-ms branch from d32e6ad to 45ff7ae Compare March 30, 2023 14:26
aduh95
aduh95 approved these changes Mar 30, 2023
View reviewed changes
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50715/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Mar 31, 2023
CI Reliability 2023-03-31 nodejs/reliability#535
Open
34 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50726/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cclauss
cclauss approved these changes Mar 31, 2023
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 31, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b541d2c into nodejs:main Mar 31, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

Landed in b541d2c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow deleted the fix-duration-ms branch March 31, 2023 12:25
This was referenced Apr 1, 2023
CI Reliability 2023-04-01 nodejs/reliability#536
Open
CI Reliability 2023-04-02 nodejs/reliability#537
Open
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@MoLow @RafaelGSS
tools: fix duration_ms to be milliseconds
e574827 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@MoLow @RafaelGSS
tools: fix duration_ms to be milliseconds
15e68fa 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@MoLow @RafaelGSS
tools: fix duration_ms to be milliseconds
8ad53a1 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@MoLow @RafaelGSS
tools: fix duration_ms to be milliseconds
03b6650 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
tools: fix duration_ms to be milliseconds
6ab2215 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
@richardlau richardlau mentioned this pull request Aug 24, 2023
Release plan - v16.x Maintenance nodejs/Release#658
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@himself65 himself65 himself65 approved these changes
@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@cclauss cclauss cclauss approved these changes
@aduh95 aduh95 aduh95 approved these changes
@juanarbol juanarbol juanarbol approved these changes
@cjihrig cjihrig Awaiting requested review from cjihrig
@Trott Trott Awaiting requested review from Trott

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@MoLow @nodejs-github-bot @jasnell @benjamingr @cclauss @himself65 @aduh95 @juanarbol @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.