GeezerVison

Review requested:

• @nodejs/gyp
• @nodejs/modules
• @nodejs/startup

Can you removed the (cherry picked from commit …) in the commit message? It is probably appended because you used the -x flag of git cherry-pick, but we don't want it in the nodejs/node repo (ncu will take care of appending the correct metadata).

Can you removed the (cherry picked from commit …) in the commit message? It is probably appended because you used the -x flag of git cherry-pick, but we don't want it in the nodejs/node repo (ncu will take care of appending the correct metadata).

done

@aduh95 what is the procedure of landing this into v18.x-staging?

@aduh95 what is the procedure of landing this into v18.x-staging?

I know the rule for LTS is to leave it to the appropriate team:

As v18.x is not (yet) LTS, the rule might be different, but I would leave it up to @nodejs/releasers to leave them full control over the release process.

CI: https://ci.nodejs.org/job/node-test-pull-request/46518/

can you include the metadata to your commit according to item 9 of https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md guideline?

@RafaelGSS isn't that done by ncu upon landing?

@RafaelGSS added metadata and squashed - as discussed in slack

CI: https://ci.nodejs.org/job/node-test-pull-request/46611/

CI: https://ci.nodejs.org/job/node-test-pull-request/46618/

Landed in 4700ee5

It didn't land cleanly on the proposal branch. Can you please rebase and run the CI again? See #44799 (comment)

@RafaelGSS the cause was a merge mess up resulting with both test/parallel/test-watch-mode.mjs and test/sequential/test-watch-mode.mjs in nodejs:v18.x-staging when only one should have existed. I will create a new backport PR with all the relevant commits in a single PR