GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] test_runner: support using `--inspect` with `--test` by MoLow · Pull Request #44813 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Sep 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

this backport PR includes
#44520
#44592
#44620

to be merged after / on top of #44815

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v18.x labels Sep 29, 2022
@MoLow
MoLow force-pushed the backport-test-runner-inspect branch from 1cffc6c to 9fbebd2 Compare September 29, 2022 08:54
@MoLow

MoLow commented Sep 29, 2022

Copy link
Copy Markdown
Member Author

CC @nodejs/releasers
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow force-pushed the backport-test-runner-inspect branch from 9fbebd2 to c743751 Compare September 29, 2022 09:04
@MoLow MoLow changed the title [v18.x backport] test_runner: support using --inspect with --test [v18.x backport] test_runner: support using --inspect with --test Sep 29, 2022
@MoLow
MoLow force-pushed the backport-test-runner-inspect branch from c743751 to 37d1e5a Compare September 29, 2022 13:58
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Sep 30, 2022
CI Reliability 2022-09-30 nodejs/reliability#390
Open
17 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46950/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 1, 2022
CI Reliability 2022-10-01 nodejs/reliability#391
Open
CI Reliability 2022-10-02 nodejs/reliability#392
Open
MoLow added 3 commits October 2, 2022 13:49
@MoLow
test_runner: support using --inspect with --test
faa8f8a 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow
cluster: use inspector utils
b48c9a5 
PR-URL: nodejs#44592
Backport-PR-URL: nodejs#44813
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow
test: fix test-runner-inspect
a797681 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow
MoLow force-pushed the backport-test-runner-inspect branch from 37d1e5a to a797681 Compare October 2, 2022 10:50
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46994/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS approved these changes Oct 2, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Oct 3, 2022
CI Reliability 2022-10-03 nodejs/reliability#393
Open
9 tasks
@MoLow

MoLow commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

CC @danielleadams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Oct 3, 2022
danielleadams
danielleadams approved these changes Oct 4, 2022
View reviewed changes
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
@MoLow @danielleadams
test_runner: support using --inspect with --test
3c1e9d4 
PR-URL: #44520
Backport-PR-URL: #44813
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
@MoLow @danielleadams
cluster: use inspector utils
7fb9cc7 
PR-URL: #44592
Backport-PR-URL: #44813
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
@MoLow @danielleadams
test: fix test-runner-inspect
56c9c98 
PR-URL: #44620
Backport-PR-URL: #44813
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams

danielleadams commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Landed in 36227ed...56c9c98
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams closed this Oct 4, 2022
@github-actions github-actions Bot mentioned this pull request Oct 5, 2022
CI Reliability 2022-10-05 nodejs/reliability#395
Open
19 tasks
@MoLow
MoLow deleted the backport-test-runner-inspect branch October 12, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes
+1 more reviewer
@danielleadams danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@MoLow @nodejs-github-bot @danielleadams @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.