GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v16.x backport] crypto: fix webcrypto generateKey() AES key length validation error by panva · Pull Request #44835 · nodejs/node

Conversation

@panva

@panva panva commented Sep 30, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs: #44170

This backports the runtime functionality without the portion that updated the wpt status file which in turn depended on the WPT Runner update (#43455).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. v16.x labels Sep 30, 2022
@panva
crypto: fix webcrypto generateKey() AES key length validation error
680718c 
PR-URL: nodejs#44170
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#44835
@panva
panva force-pushed the backport-44170-to-v16.x branch from 7772162 to 680718c Compare September 30, 2022 12:02
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva

panva commented Sep 30, 2022

Copy link
Copy Markdown
Member Author

cc @juanarbol this is the best I can do without having to backport the WPT runner update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva mentioned this pull request Sep 30, 2022
[v16.x backport] test,crypto: update WebCryptoAPI WPT #44839
Closed
@panva panva added webcrypto Issues and PRs related to the Web Crypto API. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 30, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46999/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva closed this Oct 3, 2022
This was referenced Oct 4, 2022
CI Reliability 2022-10-04 nodejs/reliability#394
Open
CI Reliability 2022-10-05 nodejs/reliability#395
Open
CI Reliability 2022-10-06 nodejs/reliability#396
Open
@panva
panva deleted the backport-44170-to-v16.x branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@panva @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.