GeezerVison

Review requested:

• @nodejs/net
• @nodejs/v8-update

Changes to upstream dependencies need to be made in the appropriate respective repositories instead of this repository.

Following up to what @mscdex said, here are their relevant repositories/sources so you can contribute the proposed changes easily:

The proposed changes to the deps directory must be forwarded to their respective repositories/sources instead, shown in the following:

base64: https://github.com/aklomp/base64
cares: https://github.com/c-ares/c-ares
histogram: https://github.com/HdrHistogram/HdrHistogram_c
icu-small: https://github.com/unicode-org/icu (ICU-small is ICU but rebuilt for repeatability, verifiability, and compatibility, see the relevant part of the maintaining ICU guide here)
npm: https://github.com/npm/cli
openssl: https://github.com/openssl/openssl
undici: https://github.com/nodejs/undici
v8: https://v8.dev/docs/contribute
zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib (the Zlib dependency we use is a fork by the Chromium team that applies fixes/optimizations that are not available in the standard Zlib)

The proposed changes to the test/fixtures/wpt directory must be forwarded to https://github.com/web-platform-tests/wpt

The proposed changes to the tools/node_modules/eslint directory must be forwarded to https://github.com/eslint/eslint

Although your change to the test/parallel directory is correct, you may want to either remove the other changes and leave that one only, or open a new PR.

Sorry, I somehow missed the part of the contribution guide about the dependencies. 🤦‍♂️
Thank you for the answer, especially @VoltrexMaster for such a detailed explanation!

I have reverted all the upstream changes and this PR is now only changing test/parallel directory.

I would recommend changing the commit message title to start with test: instead of src: since this change only affect the test directory.

Also be sure to remove the merge commit and rebase the other commits on top of your branch instead of adding them manually, only the latest commit is needed.

@VoltrexMaster I have updated the commit message and rebased but I'm not sure if that's what you have requested. If not then please advice me on what to do here.

@VoltrexMaster I have updated the commit message and rebased but I'm not sure if that's what you have requested. If not then please advice me on what to do here.

Not what I actually requested, you should use an interactive rebase to drop the older commits and only keep the latest commit (with it's commit message edited to reflect the message of this PR), and instead of merging the upstream changes on your fork to be up-to-date you should pull the upstream changes and rebase by just running git pull --rebase upstream main.

Landed in 84044df, thanks for the contribution 🎉