GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — module: fix invalid segment deprecation for imports field by guybedford · Pull Request #44883 · nodejs/node

Conversation

@guybedford

@guybedford guybedford commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

While reviewing the backport requirements for #44477 today I noticed I missed handling the "imports" case properly in the runtime deprecation message - this fixes that so that the deprecation message references the "imports" or "exports" field properly depending on which is causing the issue (it always logs it as an "exports" issue even for imports otherwise).

I also noticed that the double slash message wasn't being shown when the double slash is part of the pattern match and pattern replacement (invalid module specifier error instead of package target error). I've also made this adjustment as well.

//cc @nodejs/modules

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@guybedford
module: fix invalid segment deprecation for imports field
e670234
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guybedford
guybedford requested review from JakobJingleheimer and aduh95 October 3, 2022 22:35
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Oct 3, 2022
GeoffreyBooth
GeoffreyBooth approved these changes Oct 3, 2022
View reviewed changes
@GeoffreyBooth GeoffreyBooth added the module Issues and PRs related to the module subsystem. label Oct 3, 2022
JakobJingleheimer
JakobJingleheimer approved these changes Oct 4, 2022
View reviewed changes

@JakobJingleheimer JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🙌

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47066/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 10, 2022
View reviewed changes
aduh95
aduh95 approved these changes Oct 10, 2022
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 10, 2022
@guybedford

guybedford commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

Landed in 15f1051.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
guybedford added a commit that referenced this pull request Oct 13, 2022
@guybedford
module: fix segment deprecation for imports field
15f1051 
PR-URL: #44883
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@guybedford guybedford closed this Oct 13, 2022
@guybedford
guybedford deleted the imports-deprecation-msg branch October 13, 2022 14:32
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@guybedford @danielleadams
module: fix segment deprecation for imports field
fd33895 
PR-URL: #44883
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@guybedford @danielleadams
module: fix segment deprecation for imports field
2c0f7d4 
PR-URL: #44883
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@guybedford @nodejs-github-bot @jasnell @GeoffreyBooth @JakobJingleheimer @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.