GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — perf_hooks: convert maxSize to IDL value in setResourceTimingBufferSize by legendecas · Pull Request #44902 · nodejs/node

Conversation

@legendecas

@legendecas legendecas commented Oct 6, 2022

Copy link
Copy Markdown
Member

ECMAScript values of WebIDL interface parameters should be converted to
IDL representatives before the actual implementation, as defined in step
11.5 of the WebIDL Overload resolution algorithm.

Refs: https://webidl.spec.whatwg.org/#dfn-create-operation-function
Refs: https://webidl.spec.whatwg.org/#es-overloads

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@legendecas
perf_hooks: convert maxSize to IDL value in setResourceTimingBufferSize
5825e93 
ECMAScript values of WebIDL interface parameters should be converted to
IDL representatives before the actual implementation, as defined in step
11.5 of the WebIDL Overload resolution algorithm.

Refs: https://webidl.spec.whatwg.org/#dfn-create-operation-function
Refs: https://webidl.spec.whatwg.org/#es-overloads
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 6, 2022
anonrig
anonrig reviewed Oct 6, 2022
View reviewed changes
Comment thread lib/internal/webidl.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/webidl.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/webidl.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
fixup! perf_hooks: convert maxSize to IDL value in setResourceTimingB…
ff67498 
…ufferSize
jasnell
jasnell approved these changes Oct 10, 2022
View reviewed changes
@legendecas legendecas added perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 10, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47159/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 11, 2022
CI Reliability 2022-10-11 nodejs/reliability#401
Open
15 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47184/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 12, 2022
CI Reliability 2022-10-12 nodejs/reliability#402
Open
19 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47211/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 13, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 7cdf745 into nodejs:main Oct 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2022

Copy link
Copy Markdown
Collaborator

Landed in 7cdf745
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
legendecas deleted the resource-timing-idlharness branch October 13, 2022 17:25
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged
@danielleadams

danielleadams commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

@legendecas should this land in v18.x? If so, can you open a backport PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams added the backport-requested-v18.x label Dec 12, 2022
@legendecas legendecas mentioned this pull request Dec 12, 2022
[v18.x] perf_hooks: convert maxSize to IDL value in setResourceTimingBufferSize #45829
Closed
@legendecas

legendecas commented Dec 12, 2022

Copy link
Copy Markdown
Member Author

@danielleadams yeah, this should be a bug fix. Submitted #45829!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas added backport-open-v18.x and removed backport-requested-v18.x labels Jan 2, 2023
legendecas added a commit to legendecas/node that referenced this pull request Aug 17, 2023
@legendecas
perf_hooks: convert maxSize to IDL value in setResourceTimingBufferSize
62c113a 
ECMAScript values of WebIDL interface parameters should be converted to
IDL representatives before the actual implementation, as defined in step
11.5 of the WebIDL Overload resolution algorithm.

Refs: https://webidl.spec.whatwg.org/#dfn-create-operation-function
Refs: https://webidl.spec.whatwg.org/#es-overloads
PR-URL: nodejs#44902
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
@legendecas @ruyadorno
perf_hooks: convert maxSize to IDL value in setResourceTimingBufferSize
121f74c 
ECMAScript values of WebIDL interface parameters should be converted to
IDL representatives before the actual implementation, as defined in step
11.5 of the WebIDL Overload resolution algorithm.

Backport-PR-URL: #45829
Refs: https://webidl.spec.whatwg.org/#dfn-create-operation-function
Refs: https://webidl.spec.whatwg.org/#es-overloads
PR-URL: #44902
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 1, 2023
v18.18.0 proposal #49220
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig left review comments
@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@legendecas @nodejs-github-bot @danielleadams @jasnell @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.