GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: improve assertions in `test-repl-unsupported-option.js` by juanarbol · Pull Request #44953 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Oct 10, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@juanarbol
test: improve assertions in test-repl-unsupported-option.js
d935ecc
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 10, 2022
lpinca
lpinca approved these changes Oct 10, 2022
View reviewed changes
JungMinu
JungMinu approved these changes Oct 11, 2022
View reviewed changes
cola119
cola119 approved these changes Oct 11, 2022
View reviewed changes

@cola119 cola119 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cola119 cola119 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 11, 2022
BridgeAR
BridgeAR approved these changes Oct 11, 2022
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47199/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cola119

cola119 commented Oct 11, 2022

Copy link
Copy Markdown
Member

I noticed lib/internal/main/repl.jsL33-L38 is not covered at some point 🤔
It was surely covered until 04/08/2022, but no longer covered from 05/08/2022
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Oct 11, 2022
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI is happy.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@juanarbol juanarbol added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44953
✔  Done loading data for nodejs/node/pull/44953
----------------------------------- PR info ------------------------------------
Title      test: improve assertions in `test-repl-unsupported-option.js` (#44953)
Author     Juan José  (@juanarbol)
Branch     juanarbol:juan/endurance-asserts-repl-test -> nodejs:main
Labels     test, author ready, needs-ci
Commits    1
 - test: improve assertions in `test-repl-unsupported-option.js`
Committers 1
 - Juan José Arboleda 
PR-URL: https://github.com/nodejs/node/pull/44953
Reviewed-By: Luigi Pinca 
Reviewed-By: Minwoo Jung 
Reviewed-By: Kohei Ueno 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44953
Reviewed-By: Luigi Pinca 
Reviewed-By: Minwoo Jung 
Reviewed-By: Kohei Ueno 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 10 Oct 2022 19:31:20 GMT
   ✔  Approvals: 5
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44953#pullrequestreview-1136460634
   ✔  - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/44953#pullrequestreview-1136738208
   ✔  - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/44953#pullrequestreview-1138243493
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/44953#pullrequestreview-1138244930
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/44953#pullrequestreview-1138255796
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-10-11T22:59:31Z: https://ci.nodejs.org/job/node-test-pull-request/47199/
- Querying data for job/node-test-pull-request/47199/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3252094696
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Oct 14, 2022
View reviewed changes
jasnell
jasnell approved these changes Oct 16, 2022
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 18, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 18, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 73dc825 into nodejs:main Oct 18, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

Landed in 73dc825
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol
juanarbol deleted the juan/endurance-asserts-repl-test branch October 24, 2022 13:48
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@juanarbol @RafaelGSS
test: improve assertions in test-repl-unsupported-option.js
7858e70 
PR-URL: #44953
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@juanarbol @RafaelGSS
test: improve assertions in test-repl-unsupported-option.js
71b8d50 
PR-URL: #44953
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@juanarbol @danielleadams
test: improve assertions in test-repl-unsupported-option.js
30b42a0 
PR-URL: #44953
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@juanarbol @danielleadams
test: improve assertions in test-repl-unsupported-option.js
fc58b61 
PR-URL: #44953
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@JungMinu JungMinu JungMinu approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@cola119 cola119 cola119 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@juanarbol @nodejs-github-bot @cola119 @jasnell @lpinca @anonrig @cjihrig @JungMinu @BridgeAR @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.