GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add test to improve coverage in test-http2-compat-serverresponse-write.js by Cesar-M-Diaz · Pull Request #44970 · nodejs/node

Conversation

@Cesar-M-Diaz

@Cesar-M-Diaz Cesar-M-Diaz commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

Added a test to complement the test coverage on this file test-http2-compat-serverresponse-write.js

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
simon0191 and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 11, 2022
juanarbol
juanarbol approved these changes Oct 11, 2022
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca reviewed Oct 11, 2022
View reviewed changes
Comment thread test/parallel/test-http2-compat-serverresponse-write.js Outdated

@lpinca lpinca Oct 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both this and client.destroy(); below needed? I would keep only one if possible.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Cesar-M-Diaz Cesar-M-Diaz Oct 11, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is not necessary, just pushed a new commit for that. Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Cesar-M-Diaz
test: add test to improve coverage in http2-compat-serverresponse
60dfde0
@Cesar-M-Diaz
Cesar-M-Diaz force-pushed the test-fix-1 branch from 0c1dfec to 60dfde0 Compare October 12, 2022 14:26
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 12, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47224/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol

juanarbol commented Oct 13, 2022

Copy link
Copy Markdown
Member

CI failing is not related to this change. Requesting a CI run again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 13, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47268/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47271/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
edsadr
edsadr approved these changes Oct 14, 2022
View reviewed changes

@edsadr edsadr left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Cesar-M-Diaz

Cesar-M-Diaz commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

@lpinca PTAL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Oct 14, 2022

Copy link
Copy Markdown
Member

@Cesar-M-Diaz it seems good to me but I'm not sure I understand what is tested in particular. Can you please add a comment or clarify how coverage is increased with a link or an image? Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Cesar-M-Diaz

Cesar-M-Diaz commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

@lpinca Im covering this statement with the test
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 14, 2022
View reviewed changes
@lpinca

lpinca commented Oct 14, 2022

Copy link
Copy Markdown
Member

Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 4264b19 into nodejs:main Oct 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4264b19
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 18, 2022
CI Reliability 2022-10-18 nodejs/reliability#403
Open
CI Reliability 2022-10-19 nodejs/reliability#404
Open
CI Reliability 2022-10-20 nodejs/reliability#405
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@Cesar-M-Diaz @RafaelGSS
test: add test to improve coverage in http2-compat-serverresponse
1e67dda 
PR-URL: #44970
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@Cesar-M-Diaz @RafaelGSS
test: add test to improve coverage in http2-compat-serverresponse
ea0cfc9 
PR-URL: #44970
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Cesar-M-Diaz @danielleadams
test: add test to improve coverage in http2-compat-serverresponse
45ad2cc 
PR-URL: #44970
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Cesar-M-Diaz @danielleadams
test: add test to improve coverage in http2-compat-serverresponse
6e3227b 
PR-URL: #44970
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@juanarbol juanarbol juanarbol approved these changes
+1 more reviewer
@edsadr edsadr edsadr approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Cesar-M-Diaz @nodejs-github-bot @juanarbol @lpinca @edsadr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.