GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v16.x backport] watch mode by MoLow · Pull Request #44976 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Oct 12, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

backport of
#44366
#44551
#44621
#44739

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v16.x labels Oct 12, 2022
@MoLow MoLow added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Oct 12, 2022
@MoLow
MoLow force-pushed the backport-v16-watch-mode branch from e3581a5 to cd3a54f Compare October 12, 2022 09:29
@MoLow
MoLow marked this pull request as ready for review October 12, 2022 09:31
@MoLow
MoLow force-pushed the backport-v16-watch-mode branch from cd3a54f to 72bf89e Compare October 12, 2022 16:22
MoLow added 4 commits October 12, 2022 22:44
@MoLow
cli: add --watch
4c6ac5d
PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44976
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@MoLow
test: split watch mode inspector tests to sequential
880c48d
PR-URL: nodejs#44551
Backport-PR-URL: nodejs#44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
@MoLow
test: deflake watch mode tests
fc94a10
PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow
test: fix watch mode test flake
d8f559e
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow
MoLow force-pushed the backport-v16-watch-mode branch from 72bf89e to d8f559e Compare October 12, 2022 19:44
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 13, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 13, 2022
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47250/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mfranzke mfranzke mentioned this pull request Oct 13, 2022
replace nodemon db-ui/base#89
Open
danielleadams
danielleadams approved these changes Oct 14, 2022
View reviewed changes
JungMinu
JungMinu approved these changes Oct 17, 2022
View reviewed changes
@MoLow MoLow added the watch-mode Issues and PRs related to watch mode. label Oct 18, 2022
@MoLow

MoLow commented Oct 29, 2022

Copy link
Copy Markdown
Member Author

@nodejs/releasers Hey, can this be merged in advance, a few days before the next node 16 release? #44873 depends on it

ronjouch reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow mentioned this pull request Nov 23, 2022
[v16.x backport] test runner additions #44873
Closed
richardlau pushed a commit that referenced this pull request Nov 23, 2022
@MoLow @richardlau
cli: add --watch
1e0dcd1
PR-URL: #44366
Backport-PR-URL: #44976
Fixes: #40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
@MoLow @richardlau
test: split watch mode inspector tests to sequential
97f6caf
PR-URL: #44551
Backport-PR-URL: #44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
@MoLow @richardlau
test: deflake watch mode tests
543d3d2
PR-URL: #44621
Backport-PR-URL: #44976
Fixes: #44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
@MoLow @richardlau
test: fix watch mode test flake
6d736a5
PR-URL: #44739
Backport-PR-URL: #44976
Fixes: #44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@richardlau

richardlau commented Nov 23, 2022

Copy link
Copy Markdown
Member

Landed in 6f541d9...6d736a5

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau closed this Nov 23, 2022
@MoLow
MoLow deleted the backport-v16-watch-mode branch November 23, 2022 22:06
@MoLow MoLow added the backported-to-v16.x label Nov 23, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
cli: add --watch
5cbcf30
PR-URL: nodejs/node#44366
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: split watch mode inspector tests to sequential
f9e84ab
PR-URL: nodejs/node#44551
Backport-PR-URL: nodejs/node#44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: deflake watch mode tests
6636478
PR-URL: nodejs/node#44621
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: fix watch mode test flake
f2117be
PR-URL: nodejs/node#44739
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
cli: add --watch
8631c77
PR-URL: nodejs/node#44366
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: split watch mode inspector tests to sequential
e4d5211
PR-URL: nodejs/node#44551
Backport-PR-URL: nodejs/node#44976
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: deflake watch mode tests
f8bdc2e
PR-URL: nodejs/node#44621
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: fix watch mode test flake
fb703a7
PR-URL: nodejs/node#44739
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@richardlau richardlau mentioned this pull request Jan 5, 2023
Metadata Proposal for Docs nodejs/next-10#166
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JungMinu JungMinu JungMinu approved these changes
+1 more reviewer
@danielleadams danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@MoLow @nodejs-github-bot @richardlau @JungMinu @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.