GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: refactor promises to async/await by sonimadhuri · Pull Request #44980 · nodejs/node

Conversation

@sonimadhuri

@sonimadhuri sonimadhuri commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 12, 2022
@sonimadhuri
test: refactor promises to async/await
52a9c92
@sonimadhuri
sonimadhuri force-pushed the refactor/debugger_test_promise_to_async_await branch from 17c0c41 to 52a9c92 Compare October 12, 2022 17:00
Trott
Trott approved these changes Oct 13, 2022
View reviewed changes
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 13, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47240/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47252/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 13, 2022
@Trott

Trott commented Oct 13, 2022

Copy link
Copy Markdown
Member

@nodejs/testing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams
danielleadams approved these changes Oct 13, 2022
View reviewed changes
ljharb
ljharb reviewed Oct 13, 2022
View reviewed changes

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conversion looks correct

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/sequential/test-debugger-break.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 13, 2022
View reviewed changes
antsmartian
antsmartian approved these changes Oct 13, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2022
@nodejs-github-bot
nodejs-github-bot merged commit fe520f8 into nodejs:main Oct 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2022

Copy link
Copy Markdown
Collaborator

Landed in fe520f8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 18, 2022
CI Reliability 2022-10-18 nodejs/reliability#403
Open
CI Reliability 2022-10-19 nodejs/reliability#404
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@sonimadhuri @RafaelGSS
test: refactor promises to async/await
61a41b3 
PR-URL: #44980
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@sonimadhuri @RafaelGSS
test: refactor promises to async/await
c59d3b7 
PR-URL: #44980
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@sonimadhuri @danielleadams
test: refactor promises to async/await
85a25de 
PR-URL: #44980
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@sonimadhuri @danielleadams
test: refactor promises to async/await
657756f 
PR-URL: #44980
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments
@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
+2 more reviewers
@antsmartian antsmartian antsmartian approved these changes
@danielleadams danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@sonimadhuri @nodejs-github-bot @Trott @ljharb @antsmartian @lpinca @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.