GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix undici version in changelog by mhdawson · Pull Request #44982 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Oct 12, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The last PR to update the undici version in V18 and V16 had two commits. One to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like
when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs.

I don't think we can necessarily change the commit message in the commit, but I think having the
changelogs indicate the correct version makes sense even without that change.

This PR updates the version in the two changelogs.

Signed-off-by: Michael Dawson [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
doc: fix undici version in changelog
17dec47 
The last PR to update the undici version in V18 and
V16 had two commits. Once to update to 5.9.1 and one
to upodate to 5.10.0. Unfortunately it looks like
when squashed the commit indicates 5.9.1 which was
reported as confusing in the changelogs.

I don't think we can necessarily change the commit
message in the commit, but I think having the
changelogs indicate the correct version makes
sense even without that change.

This PR updates the version in the two changelogs.

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Oct 12, 2022
@mhdawson mhdawson mentioned this pull request Oct 12, 2022
deps: update undici to 5.10.0 #44319
Merged
@mhdawson

mhdawson commented Oct 12, 2022

Copy link
Copy Markdown
Member Author

I think the problem was that since the bot was used to land the PR it squashed the two commits and kept the message from the first one.

I'm not sure what we can do to avoid this from happening in the future. I guess in this case it probably should have been tagged so that it would not have been squashed.

If anybody has any other suggestions of what we might do to handle this in the future I think this PR is a reasonable place to discuss them.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 12, 2022
View reviewed changes
BethGriggs
BethGriggs approved these changes Oct 12, 2022
View reviewed changes
@richardlau

richardlau commented Oct 12, 2022

Copy link
Copy Markdown
Member

If anybody has any other suggestions of what we might do to handle this in the future I think this PR is a reasonable place to discuss them.

Maybe make the tools workflow add commit-queue-rebase label to the PRs it opens?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Oct 14, 2022
View reviewed changes
@mhdawson

mhdawson commented Oct 14, 2022

Copy link
Copy Markdown
Member Author

Maybe make the tools workflow add commit-queue-rebase label to the PRs it opens?

@Trott since I think you created the action in the first place does that seem reasonable to you?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson added a commit that referenced this pull request Oct 14, 2022
@mhdawson
doc: fix undici version in changelog
10f9367 
The last PR to update the undici version in V18 and
V16 had two commits. Once to update to 5.9.1 and one
to upodate to 5.10.0. Unfortunately it looks like
when squashed the commit indicates 5.9.1 which was
reported as confusing in the changelogs.

I don't think we can necessarily change the commit
message in the commit, but I think having the
changelogs indicate the correct version makes
sense even without that change.

This PR updates the version in the two changelogs.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44982
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@mhdawson

mhdawson commented Oct 14, 2022

Copy link
Copy Markdown
Member Author

Landed in 10f93679c531Landed in 10f9367
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Oct 14, 2022
@Trott

Trott commented Oct 14, 2022

Copy link
Copy Markdown
Member

Maybe make the tools workflow add commit-queue-rebase label to the PRs it opens?

@Trott since I think you created the action in the first place does that seem reasonable to you?

I think so, but I haven't tested that or anything.....
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@mhdawson @RafaelGSS
doc: fix undici version in changelog
0c7ca2a 
The last PR to update the undici version in V18 and
V16 had two commits. Once to update to 5.9.1 and one
to upodate to 5.10.0. Unfortunately it looks like
when squashed the commit indicates 5.9.1 which was
reported as confusing in the changelogs.

I don't think we can necessarily change the commit
message in the commit, but I think having the
changelogs indicate the correct version makes
sense even without that change.

This PR updates the version in the two changelogs.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44982
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@mhdawson @RafaelGSS
doc: fix undici version in changelog
f0c18f0 
The last PR to update the undici version in V18 and
V16 had two commits. Once to update to 5.9.1 and one
to upodate to 5.10.0. Unfortunately it looks like
when squashed the commit indicates 5.9.1 which was
reported as confusing in the changelogs.

I don't think we can necessarily change the commit
message in the commit, but I think having the
changelogs indicate the correct version makes
sense even without that change.

This PR updates the version in the two changelogs.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44982
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@mhdawson @danielleadams
doc: fix undici version in changelog
fabc019 
The last PR to update the undici version in V18 and
V16 had two commits. Once to update to 5.9.1 and one
to upodate to 5.10.0. Unfortunately it looks like
when squashed the commit indicates 5.9.1 which was
reported as confusing in the changelogs.

I don't think we can necessarily change the commit
message in the commit, but I think having the
changelogs indicate the correct version makes
sense even without that change.

This PR updates the version in the two changelogs.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44982
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@mhdawson @danielleadams
doc: fix undici version in changelog
d7fc12f 
The last PR to update the undici version in V18 and
V16 had two commits. Once to update to 5.9.1 and one
to upodate to 5.10.0. Unfortunately it looks like
when squashed the commit indicates 5.9.1 which was
reported as confusing in the changelogs.

I don't think we can necessarily change the commit
message in the commit, but I think having the
changelogs indicate the correct version makes
sense even without that change.

This PR updates the version in the two changelogs.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44982
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos removed the release Issues and PRs related to Node.js releases. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@mhdawson @richardlau @Trott @lpinca @anonrig @BethGriggs @targos @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.