GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add notable changes to latest v18.x release changelog by danielleadams · Pull Request #44996 · nodejs/node

Conversation

@danielleadams

@danielleadams danielleadams commented Oct 14, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This adds the Notable changes header to the v18.11.0 CHANGELOG. It is needed to generate the release post with the release notes. (Coded in here: https://github.com/nodejs/nodejs.org/blob/main/scripts/release-post.js#L111-L125)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau reacted with eyes emoji
All reactions
  • 👀 1 reaction
@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Oct 14, 2022
@danielleadams danielleadams added dont-land-on-v14.x labels Oct 14, 2022
richardlau
richardlau approved these changes Oct 14, 2022
View reviewed changes
@richardlau richardlau added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 14, 2022
@github-actions

github-actions Bot commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

richardlau and MoLow reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow
MoLow approved these changes Oct 14, 2022
View reviewed changes
@danielleadams
doc: add notable changes to latest v18.x release changelog
7df1aa5
@danielleadams
danielleadams force-pushed the add-notable-changes-to-18.11.0 branch from b328663 to 7df1aa5 Compare October 14, 2022 04:00
MoLow
MoLow approved these changes Oct 14, 2022
View reviewed changes
danielleadams added a commit that referenced this pull request Oct 14, 2022
@danielleadams
doc: add notable changes to latest v18.x release changelog
37e5152
PR-URL: #44996
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@danielleadams

danielleadams commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

Landed in 37e5152

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danielleadams danielleadams closed this Oct 14, 2022
@danielleadams
danielleadams deleted the add-notable-changes-to-18.11.0 branch October 14, 2022 04:13
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams added a commit that referenced this pull request Dec 30, 2022
@danielleadams
doc: add notable changes to latest v18.x release changelog
3a015bb
PR-URL: #44996
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
danielleadams added a commit that referenced this pull request Jan 3, 2023
@danielleadams
doc: add notable changes to latest v18.x release changelog
aebf745
PR-URL: #44996
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos removed the release Issues and PRs related to Node.js releases. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@danielleadams @richardlau @MoLow @targos @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.