GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — README.md: note that we'd like to reconcile with node by piscisaureus · Pull Request #45 · nodejs/node

Conversation

@piscisaureus

@piscisaureus piscisaureus commented Dec 3, 2014

Copy link
Copy Markdown
Contributor

Note that ideally io.js and node.js will come back together one day.
I don't know if this is the right way to say it (or even if it's grammatically correct).

@iojs/tc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cjihrig

cjihrig commented Dec 3, 2014

Copy link
Copy Markdown
Contributor

Replace once with one day, and it seems fine.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bnoordhuis

bnoordhuis commented Dec 3, 2014

Copy link
Copy Markdown
Member

'Reconcile' makes it sound as if there was a painful breakup but I can't really come up with a better word. 'Merge again' or 'team up again' is not really an improvement. LGTM, then.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@piscisaureus
README.md: note that we'd like to reconcile with node
4812917
@piscisaureus
piscisaureus force-pushed the reconcile branch from e06e840 to 4812917 Compare December 3, 2014 18:14
@mikeal

mikeal commented Dec 3, 2014

Copy link
Copy Markdown
Contributor

I know that this is based on language I wrote a while back but looking at it now it raises more questions than it answers. What would it take to reconcile? Why aren't they already reconciled? And in order to answer those questions it would have to read like a letter of demands which I don't think anyone wants.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@piscisaureus

piscisaureus commented Dec 3, 2014

Copy link
Copy Markdown
Contributor Author

@mikeal

I agree that it raises questions but what doesn't. "This is a fork of joyent/node" also raises questions ("why?" for example).

The reason I propose to add this is because we want to make it clear that (at least for now) it's not a fork that will definitely go it's own direction (like mariadb or jenkins). As long as we're actively talking to Joyent, that's not the case. So I would suggest to accept that the statement doesn't answer every question anyone could ever ask, but we still show what our intentions are.

Maybe it would help to put a reference to the node advisory board in here?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@isaacs

isaacs commented Dec 3, 2014

Copy link
Copy Markdown
Contributor

-1.

The best thing to say in this readme is as little as necessary. Stick to the technical facts. We can discuss hopes and plans and feelings elsewhere.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mikeal

mikeal commented Dec 3, 2014

Copy link
Copy Markdown
Contributor

@isaacs I'm gonna created an all new fork where the entire README is my feelings :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@isaacs

isaacs commented Dec 4, 2014

Copy link
Copy Markdown
Contributor

@mikeal Call it mr.js and then you can be Mr. JavaScript.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@piscisaureus

piscisaureus commented Dec 4, 2014

Copy link
Copy Markdown
Contributor Author

I didn't say anything about feelings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@isaacs

isaacs commented Dec 4, 2014

Copy link
Copy Markdown
Contributor

Hope is a feeling.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mikeal

mikeal commented Dec 4, 2014

Copy link
Copy Markdown
Contributor

Hope is a feeling.

This just got so philosophical.

On Wednesday, December 3, 2014, Isaac Z. Schlueter [email protected]
wrote:

Hope is a feeling.

—
Reply to this email directly or view it on GitHub
#45 (comment).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@piscisaureus

piscisaureus commented Dec 4, 2014

Copy link
Copy Markdown
Contributor Author

@isaacs @mikeal
Instead of twisting my words and ridiculing me - can you stay on topic please?

The best thing to say in this readme is as little as necessary.

Why? We should be a clear as possible without producing a massive piece of text.

Stick to the technical facts. We can discuss hopes and plans and feelings elsewhere.

I didn't say feelings. I would like to point out that the line before the one I inserted reads: "We intend to release, with increasing regularity, etc...". I do not see how this is categorically different than mentioning a hope (or whatever, a goal, an ideal) to reconcile with node. It certainly is a plan.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@piscisaureus

piscisaureus commented Dec 4, 2014

Copy link
Copy Markdown
Contributor Author

If you are against it, that's okay, then tell me what your problem really is.

Maybe you don't want to reconcile with node, or you think it's not important enough to mention in the readme, or you think it should not be widely known?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rlidwka

rlidwka commented Dec 4, 2014

Copy link
Copy Markdown
Contributor

Readme does state intentions already (compatibility, release frequency), and "reconciliation" (or, should we say, "upstream merge"?) seems to be one of them.

So, it would be logical to add that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@isaacs

isaacs commented Dec 4, 2014

Copy link
Copy Markdown
Contributor

@poscisaureus I apologize, I didn't mean my comments as ridicule at all.

I simply mean that I don't think this is the place to be talking about our plans re Joyent. It's the kind of thing that belongs in a roadmap or blog post.

This is only my opinion. If I'm in the minority here I'm happy to withdraw it. It's not a strongly held opinion.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rvagg
rvagg force-pushed the v0.12 branch 4 times, most recently from d7e65ff to 185d11c Compare December 4, 2014 10:21
@mikeal

mikeal commented Dec 4, 2014

Copy link
Copy Markdown
Contributor

@piscisaureus I was ridiculing @isaacs because I thought the concept of being "anti-feelings" was funny. I didn't mean to offend you and I apologize if I did.

I'm not opposed to reconciliation, I'm just concerned about what this messaging says about the project. This messaging isn't in a vacuum and the small comments Joyent has made thus far make it sound like they don't agree with a faster pace of progress on the grounds that it hurts stability. If that's the message they're going to pursue going forward I think the strongest messaging we could have is "this is what we believe in and what we are doing." Unlike Joyent we have a clear way that people from Joyent, or anyone else, can get involved in the project and participate in decision making. The reconciliation ball is really in their court and if they aren't talking about it then I think it might be confusing for us to be talking about it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@caineio caineio added needs info and removed needs info labels Dec 8, 2014
@piscisaureus piscisaureus removed the need info label Dec 8, 2014
@cjihrig

cjihrig commented Dec 22, 2014

Copy link
Copy Markdown
Contributor

Was a resolution ever determined here?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rvagg

rvagg commented Dec 23, 2014

Copy link
Copy Markdown
Member

I would say that there is enough negativity about this added language in this thread that it's probably not mergable as is; I suspect that it may be too difficult to come up with satisfactory wording that everyone agrees on and the whole topic of iojs/io.js and joyent/node reconciliation should be left to adjacent blog posts and discussions.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@othiym23

othiym23 commented Dec 23, 2014

Copy link
Copy Markdown
Contributor

@rvagg Agreed. This isn't something that needs to be part of the repo itself.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@piscisaureus piscisaureus closed this Dec 30, 2014
@rupamkhaitan rupamkhaitan mentioned this pull request Jun 27, 2016
trap invalid opcode ip:fea6f9 #3898
Closed
boingoing pushed a commit to boingoing/node that referenced this pull request Apr 6, 2017
@jasongin
napi: Property accessors and callback data (nodejs#45)
0bdc1b8
 - Add support for property descriptors including accessor callbacks
 - Add a data pointer for function and accessor callbacks
 - Add API for defining a property using a property descriptor
 - Update the constructor API to use property descriptors
@ofrobots ofrobots mentioned this pull request Dec 28, 2018
[v10.x] deps: V8: backport 442977e #25242
Closed
2 tasks done
ofrobots added a commit to ofrobots/node that referenced this pull request Jan 29, 2019
@ofrobots
deps: V8: backport 442977e
5a6353f
Original commit message:

  Merged: [wasm] Fix dispatch table instance update

  This CL fixes a bug where the receiving instance was updated improperly
  in the dispatch table(s) of an imported table.

  BUG=chromium:875322
  R=​[email protected]
  [email protected]

  Change-Id: Iff24953a1fb6a8ab794e12a7a976d544b56fc3c2
  Originally-reviewed-on: https://chromium-review.googlesource.com/1196886
  No-Try: true
  No-Presubmit: true
  No-Treechecks: true
  Reviewed-on: https://chromium-review.googlesource.com/1212922
  Reviewed-by: Michael Starzinger <[email protected]>
  Commit-Queue: Clemens Hammacher <[email protected]>
  Cr-Commit-Position: refs/branch-heads/6.9@{nodejs#45}
  Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
  Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{nodejs#54504}

Refs: v8/v8@442977e
BethGriggs pushed a commit that referenced this pull request Feb 4, 2019
@ofrobots @BethGriggs
deps: V8: backport 442977e
e20e347
Original commit message:

  Merged: [wasm] Fix dispatch table instance update

  This CL fixes a bug where the receiving instance was updated improperly
  in the dispatch table(s) of an imported table.

  BUG=chromium:875322
  R=​[email protected]
  [email protected]

  Change-Id: Iff24953a1fb6a8ab794e12a7a976d544b56fc3c2
  Originally-reviewed-on: https://chromium-review.googlesource.com/1196886
  No-Try: true
  No-Presubmit: true
  No-Treechecks: true
  Reviewed-on: https://chromium-review.googlesource.com/1212922
  Reviewed-by: Michael Starzinger <[email protected]>
  Commit-Queue: Clemens Hammacher <[email protected]>
  Cr-Commit-Position: refs/branch-heads/6.9@{#45}
  Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
  Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}

Refs: v8/v8@442977e

PR-URL: #25242
Reviewed-By: Michaël Zasso <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@ofrobots @rvagg
deps: V8: backport 442977e
fa12b24
Original commit message:

  Merged: [wasm] Fix dispatch table instance update

  This CL fixes a bug where the receiving instance was updated improperly
  in the dispatch table(s) of an imported table.

  BUG=chromium:875322
  R=​[email protected]
  [email protected]

  Change-Id: Iff24953a1fb6a8ab794e12a7a976d544b56fc3c2
  Originally-reviewed-on: https://chromium-review.googlesource.com/1196886
  No-Try: true
  No-Presubmit: true
  No-Treechecks: true
  Reviewed-on: https://chromium-review.googlesource.com/1212922
  Reviewed-by: Michael Starzinger <[email protected]>
  Commit-Queue: Clemens Hammacher <[email protected]>
  Cr-Commit-Position: refs/branch-heads/6.9@{#45}
  Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
  Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}

Refs: v8/v8@442977e

PR-URL: #25242
Reviewed-By: Michaël Zasso <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Feb 20, 2020
repl: printing big strings results in OOM #25478
Closed
@wmertens wmertens mentioned this pull request Jun 19, 2020
uv__io_stop: Assertion `loop->watchers[w->fd] == w' failed. #33966
Closed
@silverwind silverwind mentioned this pull request Aug 20, 2020
https/http2: random crashes on macOS with simple server #34854
Closed
@EduApps-CDG EduApps-CDG mentioned this pull request Dec 12, 2021
Network issues with [email protected] #41145
Closed
@hasinoorit hasinoorit mentioned this pull request Dec 15, 2021
HTTP module can not call callback while same callback is running. #41182
Closed
@guoard guoard mentioned this pull request Dec 15, 2021
unexpected behavior with --unhandled-rejections=strict flag #41184
Closed
@dewaynesmith3711 dewaynesmith3711 mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities dewaynesmith3711/node#41
Open
@kaocher82 kaocher82 mentioned this pull request Dec 1, 2023
[Snyk] Fix for 1 vulnerabilities Xtuden-com/node#39
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@piscisaureus @cjihrig @bnoordhuis @mikeal @isaacs @rlidwka @rvagg @othiym23 @caineio
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.