GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: improve the workflow to test release binaries by RafaelGSS · Pull Request #45004 · nodejs/node

Conversation

RafaelGSS commented Oct 14, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Using this workflow we have a better test report.

I'm using it to test the new major (v19) and it only fails 2 tests (the ones I mentioned in the doc). Those failures are expected due to the test itself trusting in some variables not present in the final binary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with eyes emoji

All reactions

👀 1 reaction

nodejs-github-bot commented Oct 14, 2022

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/tsc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label

Oct 14, 2022

aduh95 reviewed

Oct 14, 2022

View reviewed changes

Comment thread

doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS force-pushed the doc/improve-binary-test branch from 9d715ce to e0588a6 Compare

October 14, 2022 19:33

aduh95 reviewed

Oct 14, 2022

View reviewed changes

Comment thread

doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

aduh95 reviewed

Oct 14, 2022

View reviewed changes

Comment thread

doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

richardlau reviewed

Oct 14, 2022

View reviewed changes

Comment thread

doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS requested review from Trott, aduh95 and richardlau

October 15, 2022 12:33

RafaelGSS force-pushed the doc/improve-binary-test branch from e0588a6 to 8d6ab7d Compare

October 15, 2022 12:34

aduh95 mentioned this pull request

Oct 15, 2022

test: skip test depending on overlapped-checker when not available #45015

Merged

RafaelGSS force-pushed the doc/improve-binary-test branch from 8d6ab7d to e72b5ec Compare

October 15, 2022 15:29


          doc: improve the workflow to test release binaries

d5a6619

RafaelGSS force-pushed the doc/improve-binary-test branch from e72b5ec to d5a6619 Compare

October 15, 2022 15:29

aduh95 reviewed

Oct 15, 2022

View reviewed changes

Comment thread

doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

aduh95 approved these changes

Oct 15, 2022

View reviewed changes

Trott approved these changes

Oct 15, 2022

View reviewed changes

aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Oct 15, 2022

lpinca approved these changes

Oct 15, 2022

View reviewed changes

jasnell approved these changes

Oct 15, 2022

View reviewed changes

jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 15, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 15, 2022

nodejs-github-bot commented Oct 15, 2022

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/45004
✔  Done loading data for nodejs/node/pull/45004
----------------------------------- PR info ------------------------------------
Title      doc: improve the workflow to test release binaries (#45004)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:doc/improve-binary-test -> nodejs:main
Labels     doc, author ready
Commits    1
 - doc: improve the workflow to test release binaries
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/45004
Reviewed-By: Antoine du Hamel 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45004
Reviewed-By: Antoine du Hamel 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 14 Oct 2022 18:12:45 GMT
   ✔  Approvals: 4
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143203862
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143215322
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143221315
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143226142
   ✖  This PR needs to wait 21 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3257083627

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Oct 15, 2022

jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label

Oct 15, 2022

github-actions Bot commented Oct 15, 2022

Copy link

Copy Markdown

Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

RafaelGSS and aduh95 reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Oct 15, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 15, 2022

nodejs-github-bot merged commit 7ceb624 into nodejs:main

Oct 15, 2022

nodejs-github-bot commented Oct 15, 2022

Copy link

Copy Markdown

Collaborator

Landed in 7ceb624

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS added a commit that referenced this pull request

Nov 1, 2022


          doc: improve the workflow to test release binaries

907ed0e

PR-URL: #45004
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

RafaelGSS mentioned this pull request

Nov 1, 2022

v19.1.0 proposal #45269

Merged

RafaelGSS added a commit that referenced this pull request

Nov 10, 2022


          doc: improve the workflow to test release binaries

e6bbc50

PR-URL: #45004
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

danielleadams mentioned this pull request

Dec 30, 2022

v18.13.0 release proposal #46025

Merged

danielleadams pushed a commit that referenced this pull request

Dec 30, 2022


          doc: improve the workflow to test release binaries

3045fa1

PR-URL: #45004
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jan 3, 2023


          doc: improve the workflow to test release binaries

875de23

PR-URL: #45004
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Reviewers

jasnell

jasnell approved these changes

Trott

Trott approved these changes

lpinca

lpinca approved these changes

aduh95

aduh95 approved these changes

richardlau

Awaiting requested review from richardlau

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

doc

Issues and PRs related to Node.js documentation.

fast-track

PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

RafaelGSS commented Oct 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 15, 2022

Uh oh!

github-actions Bot commented Oct 15, 2022

Uh oh!

nodejs-github-bot commented Oct 15, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RafaelGSS commented Oct 14, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.