GeezerVison

Copy link

Copy Markdown

Contributor

designfrontier force-pushed the feature-improve-expectation-handling-http branch from ce42fcd to 25f7e6a Compare December 31, 2015 23:16

designfrontier force-pushed the feature-improve-expectation-handling-http branch from 25f7e6a to 2343cb2 Compare January 1, 2016 06:17

designfrontier force-pushed the feature-improve-expectation-handling-http branch from 2343cb2 to 20db3fe Compare January 1, 2016 18:55

designfrontier force-pushed the feature-improve-expectation-handling-http branch 2 times, most recently from 99b615d to e7d2033 Compare January 6, 2016 14:53

designfrontier force-pushed the feature-improve-expectation-handling-http branch from e7d2033 to 810158c Compare January 8, 2016 05:53

Now returns a 417 error status or allows for an event listener on
the `checkExpectation` event. Before we were ignoring requests that
had misspelled `100-continue` values for expect headers.

This is a quick port of the work done here:
nodejs/node-v0.x-archive#7132 by alFReD-NSH
with surrounding discussion here:
nodejs/node-v0.x-archive#4651

Also updates all the instances of the deprecated
EventEmitter.listenerCount to the current self.listenerCount. Most
of these were in the new code ported over but there was another
legacy instance.

Refs: #2403
PR-URL: #4501
Reviewed-By: James M Snell <[email protected]>

Now returns a 417 error status or allows for an event listener on
the `checkExpectation` event. Before we were ignoring requests that
had misspelled `100-continue` values for expect headers.

This is a quick port of the work done here:
nodejs/node-v0.x-archive#7132 by alFReD-NSH
with surrounding discussion here:
nodejs/node-v0.x-archive#4651

Also updates all the instances of the deprecated
EventEmitter.listenerCount to the current self.listenerCount. Most
of these were in the new code ported over but there was another
legacy instance.

Refs: #2403
PR-URL: #4501
Reviewed-By: James M Snell <[email protected]>

Notable changes:

* events: make sure console functions exist (Dave) #4479
* fs: add autoClose option to fs.createWriteStream (Saquib) #3679
* http: improves expect header handling (Daniel Sellers) #4501
* node: allow preload modules with -i (Evan Lucas) #4696
* v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) #4463
* Minor performance improvements:
  - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622
  - module: cache stat() results more aggressively (Ben Noordhuis) #4575
  - querystring: improve parse() performance (Brian White) #4675

PR-URL: #4742

Notable changes:

* events: make sure console functions exist (Dave) #4479
* fs: add autoClose option to fs.createWriteStream (Saquib) #3679
* http: improves expect header handling (Daniel Sellers) #4501
* node: allow preload modules with -i (Evan Lucas) #4696
* v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) #4463
* Minor performance improvements:
  - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622
  - module: cache stat() results more aggressively (Ben Noordhuis) #4575
  - querystring: improve parse() performance (Brian White) #4675

PR-URL: #4742

In Node v5.5.0, the HTTP server became more diligent about sending a HTTP 417
Expectation Failed response if the `Expect` header was not `100-continue`.
Since `RequestHelper.httpOptions` was creating requests with an empty `Expect`
header, and did not define a `checkExpectation` event handler, the server
returned 417 errors for these requests.

Also updated `RequestHelper.sendRequest` to use the status code text as the
error message if the error response body is empty.

https://nodejs.org/en/blog/release/v5.5.0/
nodejs/node#4501
https://nodejs.org/api/http.html#http_event_checkexpectation
https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.18
https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.20
https://www.w3.org/Protocols/rfc2616/rfc2616-sec8.html#sec8.2.3

In Node v5.5.0, the HTTP server became more diligent about sending a HTTP 417
Expectation Failed response if the `Expect` header was not `100-continue`.
Since `RequestHelper.httpOptions` was creating requests with an empty `Expect`
header, and did not define a `checkExpectation` event handler, the server
returned 417 errors for these requests.

Also updated `RequestHelper.sendRequest` to use the status code text as the
error message if the error response body is empty.

https://nodejs.org/en/blog/release/v5.5.0/
nodejs/node#4501
https://nodejs.org/api/http.html#http_event_checkexpectation
https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.18
https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.20
https://www.w3.org/Protocols/rfc2616/rfc2616-sec8.html#sec8.2.3

Now returns a 417 error status or allows for an event listener on
the `checkExpectation` event. Before we were ignoring requests that
had misspelled `100-continue` values for expect headers.

This is a quick port of the work done here:
nodejs/node-v0.x-archive#7132 by alFReD-NSH
with surrounding discussion here:
nodejs/node-v0.x-archive#4651

Also updates all the instances of the deprecated
EventEmitter.listenerCount to the current self.listenerCount. Most
of these were in the new code ported over but there was another
legacy instance.

Refs: nodejs#2403
PR-URL: nodejs#4501
Reviewed-By: James M Snell <[email protected]>

Notable changes:

* events: make sure console functions exist (Dave) nodejs#4479
* fs: add autoClose option to fs.createWriteStream (Saquib) nodejs#3679
* http: improves expect header handling (Daniel Sellers) nodejs#4501
* node: allow preload modules with -i (Evan Lucas) nodejs#4696
* v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) nodejs#4463
* Minor performance improvements:
  - lib: Use arrow functions instead of bind where possible (Minwoo Jung) nodejs#3622
  - module: cache stat() results more aggressively (Ben Noordhuis) nodejs#4575
  - querystring: improve parse() performance (Brian White) nodejs#4675

PR-URL: nodejs#4742

…t "Expect" header usage

Many MPU tests were setting "Expect: application/json", a presumed
accidental misspelling of the "Accept" header. The only valid value
for the "Expect" header is "100-continue". Old muskie was using
node 0.10. Sometime after 0.10 nodejs/node#4501
changed node behaviour to respond with 417 Expectation Failed if given
a bogus "Expect" header.