GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: update AUTHORS by nodejs-github-bot · Pull Request #45020 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Oct 16, 2022

Copy link
Copy Markdown
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.mjs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot
meta: update AUTHORS
53b5c43
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 16, 2022
Trott
Trott reviewed Oct 16, 2022
View reviewed changes
Comment thread AUTHORS Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Oct 16, 2022
View reviewed changes
Comment thread AUTHORS Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott
fixup! meta: update AUTHORS
22e69ef
@Trott Trott added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Oct 16, 2022
Trott
Trott approved these changes Oct 16, 2022
View reviewed changes
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 16, 2022
@github-actions

github-actions Bot commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
lpinca and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 16, 2022
aduh95
aduh95 approved these changes Oct 16, 2022
View reviewed changes
@aduh95

aduh95 commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

I think at some point we should modify the workflow that opens the PR to make it list possible duplicates to help with reviewing (assuming it is indeed automatisable, I'm not sure).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Oct 16, 2022

Copy link
Copy Markdown
Member

I think at some point we should modify the workflow that opens the PR to make it list possible duplicates to help with reviewing (assuming it is indeed automatisable, I'm not sure).

Yeah, the output of tools/update-authors.mjs lists suspected duplicates already. See https://github.com/nodejs/node/actions/runs/3257704667/jobs/5349162871#step:3:5 for an example.

So it would just be a matter of detecting them and including them in the PR description or something like that.
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 16, 2022
View reviewed changes
RaisinTen
RaisinTen approved these changes Oct 16, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 16, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 16, 2022
@nodejs-github-bot
nodejs-github-bot merged commit c0b5c36 into main Oct 16, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2022

Copy link
Copy Markdown
Collaborator Author

Landed in c0b5c36
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot
nodejs-github-bot deleted the actions/authors-update branch October 16, 2022 14:49
@aduh95

aduh95 commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

I think at some point we should modify the workflow that opens the PR to make it list possible duplicates to help with reviewing (assuming it is indeed automatisable, I'm not sure).

Yeah, the output of tools/update-authors.mjs lists suspected duplicates already. See https://github.com/nodejs/node/actions/runs/3257704667/jobs/5349162871#step:3:5 for an example.

So it would just be a matter of detecting them and including them in the PR description or something like that.

Or even simply liking to the workflow would already greatly simplify the review process, although your proposal seems of course even better if doable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@nodejs-github-bot @RafaelGSS
meta: update AUTHORS
c542af5 
PR-URL: #45020
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@nodejs-github-bot @RafaelGSS
meta: update AUTHORS
7900810 
PR-URL: #45020
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nodejs-github-bot @danielleadams
meta: update AUTHORS
4daf4ae 
PR-URL: #45020
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@nodejs-github-bot @danielleadams
meta: update AUTHORS
9ec6117 
PR-URL: #45020
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nodejs-github-bot @aduh95 @Trott @lpinca @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.