GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: don't push null from closed promise #42694 by davedoesdev · Pull Request #45026 · nodejs/node

Conversation

@davedoesdev

@davedoesdev davedoesdev commented Oct 16, 2022 •
edited by RaisinTen
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

closed promise is subscribed to first so will be
resolved first, before any read promise.

This causes data after EOF error to be thrown.

Remove the push null from the closed promise handler. The push null gets done from the read handler
when it detects done.

Fixes: #42694

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Oct 16, 2022
@davedoesdev

davedoesdev commented Oct 16, 2022

Copy link
Copy Markdown
Contributor Author

Fixes #42694
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott reviewed Oct 16, 2022
View reviewed changes
Comment thread test/parallel/test-readable-from-web-enqueue-then-close.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47287/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daeyeon
daeyeon approved these changes Oct 17, 2022
View reviewed changes

@daeyeon daeyeon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Adding a test for stream.Duplex would be better since it's also fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@davedoesdev
stream: don't push null from closed promise #42694
c45d16b 
closed promise is subscribed to first so will be
resolved first, before any read promise.

This causes data after EOF error to be thrown.

Remove the push null from the closed promise handler.
The push null gets done from the read handler
when it detects done.
JungMinu
JungMinu approved these changes Oct 18, 2022
View reviewed changes
jasnell
jasnell approved these changes Oct 18, 2022
View reviewed changes
@daeyeon daeyeon added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 19, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 19, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47348/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 20, 2022
CI Reliability 2022-10-20 nodejs/reliability#405
Open
CI Reliability 2022-10-21 nodejs/reliability#406
Open
CI Reliability 2022-10-22 nodejs/reliability#407
Open
@daeyeon daeyeon added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 22, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 22, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 538d8ce into nodejs:main Oct 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

Landed in 538d8ce
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 23, 2022
CI Reliability 2022-10-23 nodejs/reliability#408
Open
CI Reliability 2022-10-24 nodejs/reliability#409
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@davedoesdev @RafaelGSS
stream: don't push null from closed promise #42694
83e4291 
closed promise is subscribed to first so will be
resolved first, before any read promise.

This causes data after EOF error to be thrown.

Remove the push null from the closed promise handler.
The push null gets done from the read handler
when it detects done.

PR-URL: #45026
Fixes: #42694
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
@BethGriggs BethGriggs added the lts-watch-v18.x label Nov 3, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@davedoesdev @RafaelGSS
stream: don't push null from closed promise #42694
1655532 
closed promise is subscribed to first so will be
resolved first, before any read promise.

This causes data after EOF error to be thrown.

Remove the push null from the closed promise handler.
The push null gets done from the read handler
when it detects done.

PR-URL: #45026
Fixes: #42694
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Holi0317

Holi0317 commented Dec 29, 2022

Copy link
Copy Markdown

Sorry to interrupt. Will this PR get backported to node 18? I am currently getting hit by this bug.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@davedoesdev @danielleadams
stream: don't push null from closed promise #42694
d128b58 
closed promise is subscribed to first so will be
resolved first, before any read promise.

This causes data after EOF error to be thrown.

Remove the push null from the closed promise handler.
The push null gets done from the read handler
when it detects done.

PR-URL: #45026
Fixes: #42694
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@davedoesdev @danielleadams
stream: don't push null from closed promise #42694
c514751 
closed promise is subscribed to first so will be
resolved first, before any read promise.

This causes data after EOF error to be thrown.

Remove the push null from the closed promise handler.
The push null gets done from the read handler
when it detects done.

PR-URL: #45026
Fixes: #42694
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 7, 2023
perf: Use stream around MediaProxy and FileServer misskey-dev/misskey#9453
Closed
ファイルアップロード (drive/files/create) がタイムアウトする？ misskey-dev/misskey#9489
Open
@oddeirik oddeirik mentioned this pull request Jan 26, 2023
Node v18.13.0 availability Azure/app-service-linux-docs#160
Open
@targos targos added backported-to-v18.x and removed lts-watch-v18.x labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott left review comments
@jasnell jasnell jasnell approved these changes
@JungMinu JungMinu JungMinu approved these changes
@daeyeon daeyeon daeyeon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'stream.push() after EOF' error when using Readable.fromWeb

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@davedoesdev @nodejs-github-bot @Holi0317 @jasnell @Trott @JungMinu @daeyeon @targos @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.