GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http: Add priority to common http headers by jasnell · Pull Request #45045 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Oct 17, 2022

Copy link
Copy Markdown
Member

The standard Priority header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell [email protected]

Extracted from the quic PR here: #44325

/cc @nodejs/http @nodejs/http2

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 17, 2022
@jasnell jasnell mentioned this pull request Oct 17, 2022
src: quic #44325
Closed
aduh95
aduh95 approved these changes Oct 17, 2022
View reviewed changes
@jasnell
jasnell force-pushed the add-http-priority-header branch from 424c4fe to c801c45 Compare October 17, 2022 22:11
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
jasnell
jasnell commented Oct 17, 2022
View reviewed changes
Comment thread src/node_http_common.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 17, 2022
@jasnell
jasnell force-pushed the add-http-priority-header branch from c801c45 to 8b6d4ee Compare October 17, 2022 22:46
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig approved these changes Oct 18, 2022
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mcollina
mcollina approved these changes Oct 18, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ronag
ronag approved these changes Oct 18, 2022
View reviewed changes
RafaelGSS
RafaelGSS approved these changes Oct 18, 2022
View reviewed changes
RaisinTen
RaisinTen approved these changes Oct 18, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2022 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47323/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell removed the needs-ci PRs that need a full CI run. label Oct 18, 2022
@jasnell

jasnell commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

the github action asan test is failing for entirely unrelated reasons due to a flaky watch test
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 19, 2022
CI Reliability 2022-10-19 nodejs/reliability#404
Open
15 tasks
@jasnell
http: add priority to common http headers
7f311d9 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
@jasnell
jasnell force-pushed the add-http-priority-header branch from 8b6d4ee to 7f311d9 Compare October 19, 2022 02:29
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 19, 2022
@github-actions

github-actions Bot commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.
ShogunPanda and anonrig reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 19, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45045
✔  Done loading data for nodejs/node/pull/45045
----------------------------------- PR info ------------------------------------
Title      http: Add priority to common http headers (#45045)
Author     James M Snell  (@jasnell)
Branch     jasnell:add-http-priority-header -> nodejs:main
Labels     c++, fast-track, author ready
Commits    1
 - http: add priority to common http headers
Committers 1
 - James M Snell 
PR-URL: https://github.com/nodejs/node/pull/45045
Reviewed-By: Antoine du Hamel 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Robert Nagy 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45045
Reviewed-By: Antoine du Hamel 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Robert Nagy 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - http: add priority to common http headers
   ℹ  This PR was created on Mon, 17 Oct 2022 22:05:13 GMT
   ✔  Approvals: 6
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1144864402
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145011496
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145108209
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145112248
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145659186
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145900509
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-18T14:39:41Z: https://ci.nodejs.org/job/node-test-pull-request/47323/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - http: add priority to common http headers
- Querying data for job/node-test-pull-request/47323/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3282243031
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Oct 19, 2022

Copy link
Copy Markdown
Member Author

Landed in 112bf50
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Oct 19, 2022
jasnell added a commit that referenced this pull request Oct 19, 2022
@jasnell
http: add priority to common http headers
112bf50 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
This was referenced Oct 20, 2022
CI Reliability 2022-10-20 nodejs/reliability#405
Open
CI Reliability 2022-10-21 nodejs/reliability#406
Open
CI Reliability 2022-10-22 nodejs/reliability#407
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@jasnell @RafaelGSS
http: add priority to common http headers
e52a049 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@jasnell @RafaelGSS
http: add priority to common http headers
8abc3f7 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@jasnell @danielleadams
http: add priority to common http headers
4b93fda 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@jasnell @danielleadams
http: add priority to common http headers
f222c95 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@anonrig anonrig anonrig approved these changes
@ronag ronag ronag approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@jasnell @nodejs-github-bot @mcollina @anonrig @ronag @aduh95 @RafaelGSS @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.