GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove unnecessary noop function args to `mustCall()` by aduh95 · Pull Request #45047 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

Follow up to #45027, which the first commit is from. Marking this PR as blocked PRs that are blocked by other issues or PRs. until the other PR lands.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Oct 18, 2022
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 18, 2022
Trott
Trott approved these changes Oct 18, 2022
View reviewed changes
anonrig
anonrig approved these changes Oct 18, 2022
View reviewed changes
@aduh95
test: remove unnecessary noop function args to mustCall()
0201008 
RefsL nodejs#45027
@aduh95
aduh95 force-pushed the noop branch from 1a539f5 to 0201008 Compare October 18, 2022 12:17
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed blocked PRs that are blocked by other issues or PRs. async_hooks Issues and PRs related to the async hooks subsystem. labels Oct 18, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 18, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47318/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes Oct 18, 2022
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 18, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 18, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45047
✔  Done loading data for nodejs/node/pull/45047
----------------------------------- PR info ------------------------------------
Title      test: remove unnecessary noop function args to `mustCall()` (#45047)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:noop -> nodejs:main
Labels     test, author ready, needs-ci
Commits    1
 - test: remove unnecessary noop function args to `mustCall()`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/45047
Reviewed-By: Rich Trott 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45047
Reviewed-By: Rich Trott 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 18 Oct 2022 03:00:33 GMT
   ✔  Approvals: 3
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45047#pullrequestreview-1145033188
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45047#pullrequestreview-1145441759
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45047#pullrequestreview-1145897919
   ✖  This PR needs to wait 35 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-18T12:21:00Z: https://ci.nodejs.org/job/node-test-pull-request/47318/
- Querying data for job/node-test-pull-request/47318/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3274898631
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 18, 2022
View reviewed changes
himself65
himself65 approved these changes Oct 19, 2022
View reviewed changes
@targos targos added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 20, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 2c1b9f5 into nodejs:main Oct 20, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2c1b9f5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the noop branch October 20, 2022 13:24
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@aduh95 @RafaelGSS
test: remove unnecessary noop function args to mustCall()
ec28e9b 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@aduh95 @RafaelGSS
test: remove unnecessary noop function args to mustCall()
f0480d6 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test: remove unnecessary noop function args to mustCall()
53f0afe 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
test: remove unnecessary noop function args to mustCall()
b3c4265 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@anonrig anonrig anonrig approved these changes
@himself65 himself65 himself65 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@aduh95 @nodejs-github-bot @jasnell @Trott @anonrig @himself65 @RaisinTen @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.