GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add major version note to release guide by ruyadorno · Pull Request #45054 · nodejs/node

Conversation

@ruyadorno

@ruyadorno ruyadorno commented Oct 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Adding a note on how to properly edit the the src/node_version.h file
when working on the cherry-pick step of the Release Guide when working
on a new major version release.

Signed-off-by: Ruy Adorno [email protected]

cc @BethGriggs @RafaelGSS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 18, 2022
BethGriggs
BethGriggs reviewed Oct 18, 2022
View reviewed changes
Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau reviewed Oct 18, 2022
View reviewed changes
Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS reviewed Oct 18, 2022
View reviewed changes
Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Oct 20, 2022

Copy link
Copy Markdown
Member

Maybe replace "lts" with "add major" in the commit message? This is not specific to lts and the message should start with a verb.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno

ruyadorno commented Oct 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Maybe replace "lts" with "add major" in the commit message? This is not specific to lts and the message should start with a verb.

good point! i fixed that mention in the doc file but forgot about the commit msg 😁 I'll fix it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno
doc: add major version note to release guide
ceb3604 
Adding a note on how to properly edit the the `src/node_version.h` file
when working on the cherry-pick step of the Release Guide when working
on a new major version release.

Signed-off-by: Ruy Adorno <[email protected]>
@ruyadorno
ruyadorno force-pushed the add-lts-version-update-note-on-release-guide branch from 8e5d969 to ceb3604 Compare October 20, 2022 16:17
@ruyadorno ruyadorno changed the title doc: lts version update note on the release guide doc: add major version note to release guide Oct 20, 2022
RafaelGSS
RafaelGSS approved these changes Oct 20, 2022
View reviewed changes
BethGriggs
BethGriggs approved these changes Oct 20, 2022
View reviewed changes
anonrig
anonrig approved these changes Oct 22, 2022
View reviewed changes
anonrig pushed a commit that referenced this pull request Oct 22, 2022
@ruyadorno @anonrig
doc: add major version note to release guide
58cfb32 
Adding a note on how to properly edit the the `src/node_version.h` file
when working on the cherry-pick step of the Release Guide when working
on a new major version release.

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45054
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@anonrig

anonrig commented Oct 22, 2022

Copy link
Copy Markdown
Member

Landed in 58cfb32
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig closed this Oct 22, 2022
@ruyadorno
ruyadorno deleted the add-lts-version-update-note-on-release-guide branch October 24, 2022 15:34
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@ruyadorno @RafaelGSS
doc: add major version note to release guide
1d6f34f 
Adding a note on how to properly edit the the `src/node_version.h` file
when working on the cherry-pick step of the Release Guide when working
on a new major version release.

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45054
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@ruyadorno @RafaelGSS
doc: add major version note to release guide
5190021 
Adding a note on how to properly edit the the `src/node_version.h` file
when working on the cherry-pick step of the Release Guide when working
on a new major version release.

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45054
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@ruyadorno @danielleadams
doc: add major version note to release guide
b02d067 
Adding a note on how to properly edit the the `src/node_version.h` file
when working on the cherry-pick step of the Release Guide when working
on a new major version release.

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45054
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@ruyadorno @danielleadams
doc: add major version note to release guide
b09c386 
Adding a note on how to properly edit the the `src/node_version.h` file
when working on the cherry-pick step of the Release Guide when working
on a new major version release.

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45054
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau left review comments
@anonrig anonrig anonrig approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@ruyadorno @nodejs-github-bot @targos @anonrig @richardlau @BethGriggs @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.