GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: watch mode inspect restart repeatedly by MoLow · Pull Request #45060 · nodejs/node

Conversation

MoLow commented Oct 18, 2022

Copy link

Copy Markdown

Member

Fixes: #44805

the timeout seems to occure when saving a single change of the file was not enough to trigger watch mode, so watch mode is triggerd repeatedly instead - until it succeeds to restart twice

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and benjamingr reacted with thumbs up emoji

All reactions

👍 2 reactions

nodejs-github-bot added needs-ci

PRs that need a full CI run.

test Issues and PRs related to Node.js core tests and test infrastructure. labels

Oct 18, 2022

MoLow added the watch-mode Issues and PRs related to watch mode. label

Oct 18, 2022

Trott commented Oct 19, 2022

Copy link

Copy Markdown

Member

Typo in commit: wath -> watch

MoLow reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          test: watch mode inspect restart repeatedly

04d4df4

MoLow force-pushed the make-wath-mode-inspect-test-more-robust branch from 1b8dbee to 04d4df4 Compare

October 19, 2022 05:07

Trott changed the title ~~test: wath mode inspect restart repeatedly~~ test: watch mode inspect restart repeatedly

Oct 19, 2022

MoLow commented Oct 20, 2022

Copy link

Copy Markdown

Member Author

Cc @nodejs/testing
If someone can review this it will be great

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow added the review wanted PRs that need review. label

Oct 20, 2022

Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 20, 2022

Trott commented Oct 20, 2022

Copy link

Copy Markdown

Member

@nodejs/fs

MoLow reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 20, 2022

This comment was marked as outdated.

benjamingr approved these changes

Oct 20, 2022

View reviewed changes

This comment was marked as outdated.

MoLow added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Oct 20, 2022

This comment was marked as outdated.

nodejs-github-bot commented Oct 20, 2022 •

edited by jasnell

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47371/ 💚

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Oct 21, 2022

CI Reliability 2022-10-21 nodejs/reliability#406

Open

CI Reliability 2022-10-22 nodejs/reliability#407

Open

jasnell approved these changes

Oct 22, 2022

View reviewed changes

jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 22, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 22, 2022

nodejs-github-bot merged commit 47b63f5 into nodejs:main

Oct 22, 2022

nodejs-github-bot commented Oct 22, 2022

Copy link

Copy Markdown

Collaborator

Landed in 47b63f5

benjamingr reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow deleted the make-wath-mode-inspect-test-more-robust branch

October 22, 2022 19:12

This was referenced Oct 23, 2022

CI Reliability 2022-10-23 nodejs/reliability#408

Open

CI Reliability 2022-10-24 nodejs/reliability#409

Open

CI Reliability 2022-10-25 nodejs/reliability#410

Open

RafaelGSS pushed a commit that referenced this pull request

Nov 1, 2022


          test: watch mode inspect restart repeatedly

9a146ba

PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>

RafaelGSS mentioned this pull request

Nov 1, 2022

v19.1.0 proposal #45269

Merged

RafaelGSS pushed a commit that referenced this pull request

Nov 10, 2022


          test: watch mode inspect restart repeatedly

2b3b291

PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>

danielleadams mentioned this pull request

Dec 30, 2022

v18.13.0 release proposal #46025

Merged

danielleadams pushed a commit that referenced this pull request

Dec 30, 2022


          test: watch mode inspect restart repeatedly

bdf7f25

PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jan 3, 2023


          test: watch mode inspect restart repeatedly

a8030b9

PR-URL: #45060
Fixes: #44805
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Reviewers

jasnell

jasnell approved these changes

benjamingr

benjamingr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

needs-ci

PRs that need a full CI run.

review wanted

PRs that need review.

test

Issues and PRs related to Node.js core tests and test infrastructure.

watch-mode

Issues and PRs related to watch mode.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-watch-mode-inspect

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

MoLow commented Oct 18, 2022

Uh oh!

Trott commented Oct 19, 2022

Uh oh!

MoLow commented Oct 20, 2022

Uh oh!

Trott commented Oct 20, 2022

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Oct 20, 2022 • edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 22, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nodejs-github-bot commented Oct 20, 2022 •

edited by jasnell

Loading

Uh oh!

There was an error while loading. Please reload this page.