GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: mention v18.x openssl maintaining guide by RafaelGSS · Pull Request #45070 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 19, 2022

Copy link
Copy Markdown
Member

Nothing really changed. However, it's important to ensure main now refers to the 'Current' release, v19.x.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 19, 2022
aduh95
aduh95 approved these changes Oct 19, 2022
View reviewed changes
richardlau
richardlau approved these changes Oct 19, 2022
View reviewed changes
BethGriggs
BethGriggs approved these changes Oct 19, 2022
View reviewed changes
jasnell
jasnell approved these changes Oct 19, 2022
View reviewed changes
AugustinMauroy
AugustinMauroy approved these changes Oct 20, 2022
View reviewed changes

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes Oct 20, 2022
View reviewed changes
@lpinca

lpinca commented Oct 20, 2022

Copy link
Copy Markdown
Member

Is there a typo in commit message? "migration" -> "maintaining".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes Oct 20, 2022
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS RafaelGSS changed the title doc: mention v18.x openssl migration guide doc: mention v18.x openssl maintaining guide Oct 21, 2022
@RafaelGSS
doc: mention v18.x openssl maintaining guide
e5b0dcd
@RafaelGSS
RafaelGSS force-pushed the doc/maintaining-openssl-v18 branch from 12c1c01 to e5b0dcd Compare October 21, 2022 12:57
@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45070
✔  Done loading data for nodejs/node/pull/45070
----------------------------------- PR info ------------------------------------
Title      doc: mention v18.x openssl maintaining guide (#45070)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:doc/maintaining-openssl-v18 -> nodejs:main
Labels     doc
Commits    1
 - doc: mention v18.x openssl maintaining guide
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/45070
Reviewed-By: Antoine du Hamel 
Reviewed-By: Richard Lau 
Reviewed-By: Beth Griggs 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45070
Reviewed-By: Antoine du Hamel 
Reviewed-By: Richard Lau 
Reviewed-By: Beth Griggs 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - doc: mention v18.x openssl maintaining guide
   ℹ  This PR was created on Wed, 19 Oct 2022 12:26:25 GMT
   ✔  Approvals: 6
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1147464514
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1147480751
   ✔  - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1147605979
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1148304898
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45070#pullrequestreview-1149876771
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/45070#pullrequestreview-1150058050
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3298570699
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Oct 21, 2022
View reviewed changes
@richardlau richardlau added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2022
@nodejs-github-bot
nodejs-github-bot merged commit e43d191 into nodejs:main Oct 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in e43d191
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS added a commit that referenced this pull request Nov 1, 2022
@RafaelGSS
doc: mention v18.x openssl maintaining guide
07a2ec2 
PR-URL: #45070
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS added a commit that referenced this pull request Nov 10, 2022
@RafaelGSS
doc: mention v18.x openssl maintaining guide
ee34a3a 
PR-URL: #45070
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@RafaelGSS @danielleadams
doc: mention v18.x openssl maintaining guide
1a759c4 
PR-URL: #45070
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@RafaelGSS @danielleadams
doc: mention v18.x openssl maintaining guide
5e76bf5 
PR-URL: #45070
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@aduh95 aduh95 aduh95 approved these changes
+2 more reviewers
@mhdawson mhdawson mhdawson approved these changes
@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@RafaelGSS @nodejs-github-bot @lpinca @jasnell @richardlau @BethGriggs @mhdawson @aduh95 @AugustinMauroy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.