GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix v14.x link maintaining openssl guide by RafaelGSS · Pull Request #45071 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 19, 2022

Copy link
Copy Markdown
Member

The document indicates the file lives under /blob/v14.x-staging/doc/contributing/maintaining-openssl.md which is false on v14.x branch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 19, 2022
@RafaelGSS
RafaelGSS force-pushed the doc/maintaining-openssl-v14-fix branch from 1337e2b to c04409f Compare October 19, 2022 12:40
richardlau
richardlau reviewed Oct 19, 2022
View reviewed changes
Comment thread doc/contributing/maintaining-openssl.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS
RafaelGSS force-pushed the doc/maintaining-openssl-v14-fix branch from c04409f to b571a73 Compare October 19, 2022 13:36
richardlau
richardlau approved these changes Oct 19, 2022
View reviewed changes
@aduh95

aduh95 commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

Why adding a link for v14.x and not v16.x?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS

RafaelGSS commented Oct 19, 2022

Copy link
Copy Markdown
Member Author

Why adding a link for v14.x and not v16.x?

The v16.x version of that document exists. The issue is that the v14.x of that document lives in a different namespace (guides/*)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

Oh you mean on the GitHub UI, yeah OK makes sense.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Oct 19, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jasnell
jasnell reviewed Oct 19, 2022
View reviewed changes
Comment thread doc/contributing/maintaining-openssl.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS
doc: fix v14.x link maintaining openssl guide
8231341
@RafaelGSS
RafaelGSS force-pushed the doc/maintaining-openssl-v14-fix branch from b571a73 to 8231341 Compare October 22, 2022 04:11
@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 22, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45071
✔  Done loading data for nodejs/node/pull/45071
----------------------------------- PR info ------------------------------------
Title      doc: fix v14.x link maintaining openssl guide (#45071)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:doc/maintaining-openssl-v14-fix -> nodejs:main
Labels     doc, author ready
Commits    1
 - doc: fix v14.x link maintaining openssl guide
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/45071
Reviewed-By: Richard Lau 
Reviewed-By: Matteo Collina 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45071
Reviewed-By: Richard Lau 
Reviewed-By: Matteo Collina 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - doc: fix v14.x link maintaining openssl guide
   ℹ  This PR was created on Wed, 19 Oct 2022 12:31:55 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45071#pullrequestreview-1147646586
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45071#pullrequestreview-1148034313
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3303153329
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS added a commit that referenced this pull request Oct 22, 2022
@RafaelGSS
doc: fix v14.x link maintaining openssl guide
3a4f964 
PR-URL: #45071
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@RafaelGSS

RafaelGSS commented Oct 22, 2022

Copy link
Copy Markdown
Member Author

Landed in 3a4f964
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS closed this Oct 22, 2022
RafaelGSS added a commit that referenced this pull request Nov 1, 2022
@RafaelGSS
doc: fix v14.x link maintaining openssl guide
e20f169 
PR-URL: #45071
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS added a commit that referenced this pull request Nov 10, 2022
@RafaelGSS
doc: fix v14.x link maintaining openssl guide
809e8dc 
PR-URL: #45071
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@RafaelGSS @danielleadams
doc: fix v14.x link maintaining openssl guide
0779bec 
PR-URL: #45071
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@RafaelGSS @danielleadams
doc: fix v14.x link maintaining openssl guide
896b48b 
PR-URL: #45071
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments
@mcollina mcollina mcollina approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@RafaelGSS @nodejs-github-bot @aduh95 @mcollina @jasnell @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.