GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: trace more fs api by theanarkh · Pull Request #45095 · nodejs/node

Conversation

@theanarkh

@theanarkh theanarkh commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

trace more fs api.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Oct 20, 2022
@theanarkh
theanarkh force-pushed the trace_more_fs_api branch 3 times, most recently from 11dcbf1 to 135a8b7 Compare October 20, 2022 16:53
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 22, 2022
anonrig
anonrig approved these changes Oct 22, 2022
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47404/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47414/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh
fs: trace more fs api
9d43087
@theanarkh
theanarkh force-pushed the trace_more_fs_api branch from 135a8b7 to 9d43087 Compare October 23, 2022 06:12
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47430/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh

theanarkh commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

I have removed this test, it seems unstable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 25, 2022
CI Reliability 2022-10-25 nodejs/reliability#410
Open
CI Reliability 2022-10-26 nodejs/reliability#411
Open
legendecas
legendecas approved these changes Oct 26, 2022
View reviewed changes
@theanarkh theanarkh added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 775bf62 into nodejs:main Oct 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Landed in 775bf62
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 27, 2022
CI Reliability 2022-10-27 nodejs/reliability#412
Open
CI Reliability 2022-10-28 nodejs/reliability#413
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@theanarkh @RafaelGSS
fs: trace more fs api
bd68621 
PR-URL: #45095
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@theanarkh @RafaelGSS
fs: trace more fs api
d89ca1b 
PR-URL: #45095
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
fs: trace more fs api
b1f2031 
PR-URL: #45095
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@theanarkh @danielleadams
fs: trace more fs api
da302ce 
PR-URL: #45095
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@theanarkh @nodejs-github-bot @anonrig @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.