GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update mark release line lts on release guide by ruyadorno · Pull Request #45101 · nodejs/node

Conversation

@ruyadorno

@ruyadorno ruyadorno commented Oct 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Updates the Release Guide to point to using node-core-utils for creating the commit that marks a release line as LTS.

cc @nodejs/releasers

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ruyadorno
doc: update mark release line lts on release guide
e6d1cdf
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2022 •
edited by ruyadorno
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 20, 2022
richardlau
richardlau approved these changes Oct 20, 2022
View reviewed changes
mhdawson
mhdawson approved these changes Oct 20, 2022
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
BethGriggs
BethGriggs approved these changes Oct 20, 2022
View reviewed changes
anonrig
anonrig approved these changes Oct 21, 2022
View reviewed changes
RafaelGSS
RafaelGSS reviewed Oct 21, 2022
View reviewed changes
Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

ruyadorno and others added 2 commits October 21, 2022 11:16
@ruyadorno @RafaelGSS
Update doc/contributing/releases.md
c8653ea
Co-authored-by: Rafael Gonzaga <[email protected]>
@ruyadorno @RafaelGSS
Update doc/contributing/releases.md
7c0a5cb
Co-authored-by: Rafael Gonzaga <[email protected]>
jasnell
jasnell approved these changes Oct 21, 2022
View reviewed changes
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 21, 2022
@github-actions

github-actions Bot commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

anonrig, lpinca, mhdawson, and BethGriggs reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca approved these changes Oct 21, 2022
View reviewed changes
@ruyadorno ruyadorno added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 21, 2022
@ruyadorno
Update doc/contributing/releases.md
25b4ccf
aduh95
aduh95 approved these changes Oct 22, 2022
View reviewed changes
Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ruyadorno @aduh95
Update doc/contributing/releases.md
520e533
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Oct 24, 2022
RafaelGSS
RafaelGSS approved these changes Oct 24, 2022
View reviewed changes
legendecas
legendecas approved these changes Oct 24, 2022
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 24, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 1930fcd into nodejs:main Oct 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

Landed in 1930fcd

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@ruyadorno @RafaelGSS
doc: update mark release line lts on release guide
423307c
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45101
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@ruyadorno @RafaelGSS
doc: update mark release line lts on release guide
85cb4d7
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45101
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@ruyadorno @danielleadams
doc: update mark release line lts on release guide
f390de9
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45101
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@ruyadorno @danielleadams
doc: update mark release line lts on release guide
17380a1
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45101
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
@legendecas legendecas legendecas approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@ruyadorno @nodejs-github-bot @jasnell @lpinca @anonrig @richardlau @BethGriggs @legendecas @mhdawson @aduh95 @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.