GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — dns: fix port validation by aduh95 · Pull Request #45135 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Previously the error message generation would throw if the port was of type "symbol".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
dns: fix port validation
103f234 
Previously the error message generation would throw if the port was of
type `"symbol"`.
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run. labels Oct 23, 2022
BridgeAR
BridgeAR approved these changes Oct 23, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 23, 2022
Trott
Trott approved these changes Oct 23, 2022
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
lpinca
lpinca approved these changes Oct 23, 2022
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Oct 23, 2022
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Oct 24, 2022
CI Reliability 2022-10-24 nodejs/reliability#409
Open
13 tasks
jasnell
jasnell approved these changes Oct 24, 2022
View reviewed changes
anonrig
anonrig approved these changes Oct 24, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47443/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
juanarbol
juanarbol approved these changes Oct 24, 2022
View reviewed changes
@juanarbol juanarbol added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45135
✔  Done loading data for nodejs/node/pull/45135
----------------------------------- PR info ------------------------------------
Title      dns: fix port validation (#45135)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:fix-port-validation -> nodejs:main
Labels     errors, author ready, needs-ci
Commits    1
 - dns: fix port validation
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/45135
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: James M Snell 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Juan José Arboleda 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45135
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: James M Snell 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Juan José Arboleda 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 23 Oct 2022 16:39:55 GMT
   ✔  Approvals: 7
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152334332
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152334691
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152346904
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152368653
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152591810
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152962208
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/45135#pullrequestreview-1153554466
   ✖  This PR needs to wait 22 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-24T15:11:51Z: https://ci.nodejs.org/job/node-test-pull-request/47443/
- Querying data for job/node-test-pull-request/47443/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3315003203
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 24, 2022
@github-actions github-actions Bot mentioned this pull request Oct 25, 2022
CI Reliability 2022-10-25 nodejs/reliability#410
Open
16 tasks
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 25, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 25, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 53cd3d8 into nodejs:main Oct 25, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2022

Copy link
Copy Markdown
Collaborator

Landed in 53cd3d8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the fix-port-validation branch October 25, 2022 18:38
This was referenced Oct 26, 2022
CI Reliability 2022-10-26 nodejs/reliability#411
Open
CI Reliability 2022-10-27 nodejs/reliability#412
Open
@github-actions github-actions Bot mentioned this pull request Oct 28, 2022
CI Reliability 2022-10-28 nodejs/reliability#413
Open
10 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@aduh95 @RafaelGSS
dns: fix port validation
fae4735 
Previously the error message generation would throw if the port was of
type `"symbol"`.

PR-URL: #45135
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@aduh95 @RafaelGSS
dns: fix port validation
b5baaa6 
Previously the error message generation would throw if the port was of
type `"symbol"`.

PR-URL: #45135
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@Uzlopak Uzlopak mentioned this pull request Nov 17, 2022
fix node 19.1.0 port validation test fastify/fastify#4427
Merged
4 tasks
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
dns: fix port validation
1e36d7b 
Previously the error message generation would throw if the port was of
type `"symbol"`.

PR-URL: #45135
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
dns: fix port validation
9ceed7a 
Previously the error message generation would throw if the port was of
type `"symbol"`.

PR-URL: #45135
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@juanarbol juanarbol juanarbol approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@aduh95 @nodejs-github-bot @jasnell @Trott @lpinca @anonrig @BridgeAR @juanarbol @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.