GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: expose `LookupAndCompile` with parameters by codebytere · Pull Request #45142 · nodejs/node

Conversation

@codebytere

@codebytere codebytere commented Oct 24, 2022

Copy link
Copy Markdown
Member

Refs #44018.

This PR exposes a version of LookupAndCompile that takes parameters instead of detecting them based on module IDs.

Electron currently maintains a wrapper to LookupAndCompile, which specifically requires parameters because we pass our own modules to LookupAndCompile in several places:

  • shell/common/api/electron_api_asar.cc
  • shell/renderer/electron_sandboxed_renderer_client.cc
  • shell/renderer/renderer_client_base.cc

and therefore need to be able to able to expose the ability to set that.

I do, however, see that Node.js recently added back a version of CompileAndCall which is effectively the same as our own CompileAndCall wrapper, so if it would be better to modify that to allow parameters I would also be happy to take that path.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@codebytere
codebytere requested a review from joyeecheung October 24, 2022 08:54
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere codebytere added the embedding Issues and PRs related to embedding Node.js in another project. label Oct 24, 2022
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 24, 2022
@codebytere codebytere changed the title src: expose LookupAndCompile with parameters src: expose LookupAndCompile with parameters Oct 24, 2022
joyeecheung
joyeecheung approved these changes Oct 24, 2022
View reviewed changes
Comment thread src/node_builtins.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
juanarbol
juanarbol approved these changes Oct 24, 2022
View reviewed changes
addaleax
addaleax reviewed Oct 25, 2022
View reviewed changes
Comment thread src/node_builtins.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@codebytere
codebytere force-pushed the lookup-and-compile-wrapper branch from d4d1c3a to 5f9feee Compare October 26, 2022 20:04
@codebytere
codebytere requested a review from addaleax October 26, 2022 20:04
legendecas
legendecas approved these changes Oct 31, 2022
View reviewed changes
joyeecheung
joyeecheung approved these changes Nov 1, 2022
View reviewed changes

@joyeecheung joyeecheung left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codebytere
codebytere force-pushed the lookup-and-compile-wrapper branch from 5f9feee to 3b0d0e1 Compare November 8, 2022 11:21
@nodejs nodejs deleted a comment from nodejs-github-bot Nov 8, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47785/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs nodejs deleted a comment from nodejs-github-bot Nov 8, 2022
@codebytere
src: expose LookupAndCompile with parameters
1fc633a
@codebytere
codebytere force-pushed the lookup-and-compile-wrapper branch from 3b0d0e1 to 1fc633a Compare November 8, 2022 14:22
@nodejs-github-bot

nodejs-github-bot commented Nov 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47788/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 11, 2022
CI Reliability 2022-11-11 nodejs/reliability#425
Open
CI Reliability 2022-11-12 nodejs/reliability#426
Open
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
jasnell
jasnell approved these changes Nov 16, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47996/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

This needs rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere

codebytere commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

Superseded by #53886
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codebytere codebytere closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@legendecas legendecas legendecas approved these changes
@juanarbol juanarbol juanarbol approved these changes
@addaleax addaleax Awaiting requested review from addaleax

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. embedding Issues and PRs related to embedding Node.js in another project. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@codebytere @nodejs-github-bot @aduh95 @jasnell @addaleax @joyeecheung @legendecas @juanarbol
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.