GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bootstrap: generate bootstrapper arguments in BuiltinLoader by joyeecheung · Pull Request #44488 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Sep 2, 2022

Copy link
Copy Markdown
Member

First commit comes from #44472

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joyeecheung
joyeecheung marked this pull request as ready for review September 2, 2022 06:29
@nodejs-github-bot

nodejs-github-bot commented Sep 2, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 2, 2022
@joyeecheung joyeecheung mentioned this pull request Sep 2, 2022
bootstrap: support more builtins in the embedded code cache #44018
Closed
legendecas
legendecas reviewed Sep 5, 2022
View reviewed changes

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but the linter is complaining...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung
joyeecheung force-pushed the compile-arg branch from 3ad93cc to a4c8645 Compare September 6, 2022 12:45
@joyeecheung

joyeecheung commented Sep 6, 2022

Copy link
Copy Markdown
Member Author

Rebased and fixed the linter error.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46440/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung
bootstrap: generate bootstrapper arguments in BuiltinLoader
501fee7
@joyeecheung
joyeecheung force-pushed the compile-arg branch from a4c8645 to 501fee7 Compare September 6, 2022 12:46
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46441/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46446/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas approved these changes Sep 6, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Sep 7, 2022
CI Reliability 2022-09-07 nodejs/reliability#370
Open
15 tasks
@joyeecheung joyeecheung added the review wanted PRs that need review. label Sep 7, 2022
This was referenced Sep 8, 2022
CI Reliability 2022-09-08 nodejs/reliability#371
Open
CI Reliability 2022-09-09 nodejs/reliability#372
Open
CI Reliability 2022-09-10 nodejs/reliability#373
Open
CI Reliability 2022-09-11 nodejs/reliability#374
Open
CI Reliability 2022-09-12 nodejs/reliability#375
Open
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46530/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46537/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 13, 2022
CI Reliability 2022-09-13 nodejs/reliability#376
Open
30 tasks
@joyeecheung joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 13, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 7850802 into nodejs:main Sep 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2022

Copy link
Copy Markdown
Collaborator

Landed in 7850802
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 14, 2022
CI Reliability 2022-09-14 nodejs/reliability#378
Open
28 tasks
@github-actions github-actions Bot mentioned this pull request Sep 15, 2022
CI Reliability 2022-09-15 nodejs/reliability#379
Open
29 tasks
@github-actions github-actions Bot mentioned this pull request Sep 16, 2022
CI Reliability 2022-09-16 nodejs/reliability#380
Open
23 tasks
@RafaelGSS

RafaelGSS commented Sep 26, 2022

Copy link
Copy Markdown
Member

Hi @joyeecheung. This commit didn't land cleanly on v18.x. Could you please backport?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS added the backport-requested-v18.x label Sep 26, 2022
@juanarbol

juanarbol commented Oct 3, 2022

Copy link
Copy Markdown
Member

The builtins thing did not land well in the v16.x release line (#44135); marking this as backport-blocked for the v16.x branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol added the backport-blocked-v16.x label Oct 3, 2022
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged
@joyeecheung joyeecheung mentioned this pull request Oct 14, 2022
src: consolidate exit codes in the code base #44746
Merged
@codebytere codebytere mentioned this pull request Oct 24, 2022
src: expose LookupAndCompile with parameters #45142
Closed
@legendecas legendecas mentioned this pull request May 23, 2023
src: define per-isolate internal bindings registration callback #45547
Closed
targos pushed a commit that referenced this pull request Oct 29, 2023
@joyeecheung @targos
bootstrap: generate bootstrapper arguments in BuiltinLoader
c1bc811 
PR-URL: #44488
Reviewed-By: Chengzhong Wu <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
bootstrap: generate bootstrapper arguments in BuiltinLoader
4e51651 
PR-URL: nodejs/node#44488
Reviewed-By: Chengzhong Wu <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
bootstrap: generate bootstrapper arguments in BuiltinLoader
2b0472f 
PR-URL: nodejs/node#44488
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. review wanted PRs that need review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@joyeecheung @nodejs-github-bot @RafaelGSS @juanarbol @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.