GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: make `test-eventemitter-asyncresource.js` shorter by juanarbol · Pull Request #45146 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Oct 24, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Juan José Arboleda [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 24, 2022
@juanarbol
juanarbol force-pushed the juan/refactor-events-test branch from 9dd5cc2 to b95e139 Compare October 24, 2022 13:27
lpinca
lpinca approved these changes Oct 24, 2022
View reviewed changes
Flarna
Flarna reviewed Oct 25, 2022
View reviewed changes
Comment thread test/parallel/test-eventemitter-asyncresource.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Flarna
Flarna approved these changes Oct 25, 2022
View reviewed changes
jasnell
jasnell approved these changes Oct 26, 2022
View reviewed changes
@juanarbol
test: make test-eventemitter-asyncresource.js shorter
c27bb19 
Signed-off-by: Juan José Arboleda <[email protected]>
@juanarbol
juanarbol force-pushed the juan/refactor-events-test branch from b95e139 to c27bb19 Compare October 28, 2022 17:42
Flarna
Flarna approved these changes Oct 28, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47539/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 29, 2022
CI Reliability 2022-10-29 nodejs/reliability#414
Open
CI Reliability 2022-10-30 nodejs/reliability#415
Open
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47568/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 31, 2022
CI Reliability 2022-10-31 nodejs/reliability#416
Open
19 tasks
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 1, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 74d2147 into nodejs:main Nov 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2022

Copy link
Copy Markdown
Collaborator

Landed in 74d2147
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@juanarbol @RafaelGSS
test: make test-eventemitter-asyncresource.js shorter
d5f4d98 
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #45146
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
v19.1.0 proposal #45269
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@juanarbol @danielleadams
test: make test-eventemitter-asyncresource.js shorter
8475b69 
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #45146
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@juanarbol @danielleadams
test: make test-eventemitter-asyncresource.js shorter
ab9c2df 
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #45146
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@juanarbol
juanarbol deleted the juan/refactor-events-test branch February 12, 2023 02:18
@hidaviddong hidaviddong mentioned this pull request Aug 29, 2024
test: refactor test-whatwg-webstreams-encoding to be shorter #54569
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@Flarna Flarna Flarna approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@juanarbol @nodejs-github-bot @jasnell @lpinca @Flarna
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.