GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: improve test coverage in `test-event-capture-rejections.js` by juanarbol · Pull Request #45148 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Oct 24, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Juan José Arboleda [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@juanarbol
test: improve test coverage in test-event-capture-rejections.js
d3cc9c1 
Signed-off-by: Juan José Arboleda <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 24, 2022
cjihrig
cjihrig approved these changes Oct 24, 2022
View reviewed changes
jasnell
jasnell approved these changes Oct 26, 2022
View reviewed changes
benjamingr
benjamingr approved these changes Oct 26, 2022
View reviewed changes
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 27, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 27, 2022
@juanarbol juanarbol added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47509/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47531/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 29, 2022
CI Reliability 2022-10-29 nodejs/reliability#414
Open
15 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47546/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 29, 2022
View reviewed changes
anonrig
anonrig approved these changes Oct 29, 2022
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 29, 2022
@nodejs-github-bot
nodejs-github-bot merged commit cca44bc into nodejs:main Oct 29, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2022

Copy link
Copy Markdown
Collaborator

Landed in cca44bc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 30, 2022
CI Reliability 2022-10-30 nodejs/reliability#415
Open
15 tasks
@juanarbol
juanarbol deleted the juan/events-test-coverage branch October 30, 2022 05:28
This was referenced Oct 31, 2022
CI Reliability 2022-10-31 nodejs/reliability#416
Open
CI Reliability 2022-11-01 nodejs/reliability#417
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@juanarbol @RafaelGSS
test: improve test coverage in test-event-capture-rejections.js
c73d228 
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #45148
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
@github-actions github-actions Bot mentioned this pull request Nov 2, 2022
CI Reliability 2022-11-02 nodejs/reliability#418
Open
15 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@juanarbol @RafaelGSS
test: improve test coverage in test-event-capture-rejections.js
eed799b 
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #45148
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@juanarbol @danielleadams
test: improve test coverage in test-event-capture-rejections.js
588587a 
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #45148
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@juanarbol @danielleadams
test: improve test coverage in test-event-capture-rejections.js
d718c67 
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #45148
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@juanarbol @nodejs-github-bot @jasnell @benjamingr @lpinca @anonrig @cjihrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.