GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update V8 gypfiles for RISC-V by andreas-schwab · Pull Request #45149 · nodejs/node

Conversation

@andreas-schwab

@andreas-schwab andreas-schwab commented Oct 24, 2022 •
edited by targos
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

Fixes #45059

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and olof-nord reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@andreas-schwab
tools: update V8 gypfiles for RISC-V
1637a41 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Oct 24, 2022
targos
targos approved these changes Oct 24, 2022
View reviewed changes
richardlau
richardlau approved these changes Oct 24, 2022
View reviewed changes
@richardlau

richardlau commented Oct 24, 2022

Copy link
Copy Markdown
Member

Fixes #45059 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andreas-schwab

andreas-schwab commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

Yes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the riscv64 Issues and PRs related to the 64-bit RISC-V architecture. label Oct 24, 2022
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 24, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47444/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sxa
sxa approved these changes Oct 24, 2022
View reviewed changes

@sxa sxa left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
juanarbol
juanarbol approved these changes Oct 24, 2022
View reviewed changes
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 24, 2022
gengjiawen
gengjiawen approved these changes Oct 26, 2022
View reviewed changes
@gengjiawen gengjiawen added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 26, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@gengjiawen gengjiawen removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 26, 2022
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot
nodejs-github-bot merged commit e888855 into nodejs:main Oct 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Landed in e888855
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@andreas-schwab @RafaelGSS
tools: update V8 gypfiles for RISC-V
f45dbc8 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@andreas-schwab @RafaelGSS
tools: update V8 gypfiles for RISC-V
a415869 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@andreas-schwab @danielleadams
tools: update V8 gypfiles for RISC-V
1439b34 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@andreas-schwab @danielleadams
tools: update V8 gypfiles for RISC-V
48cf890 
With the inclusion of the RISC-V 32-bit support in V8 the directory
src/heap/base/asm/riscv64 has been renamed to riscv.

PR-URL: #45149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos added dont-land-on-v14.x labels Jan 10, 2023
@F3n67u F3n67u mentioned this pull request Jan 11, 2023
Changed the riscv64 compilation path to the wrong one #46154
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@sxa sxa sxa approved these changes
@juanarbol juanarbol juanarbol approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. riscv64 Issues and PRs related to the 64-bit RISC-V architecture. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

riscv64 (unofficial) builds of v19.0.0 failed

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@andreas-schwab @nodejs-github-bot @richardlau @targos @gengjiawen @sxa @juanarbol @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.