GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — buffer: fix validation of options in `Blob` constructor by aduh95 · Pull Request #45156 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Oct 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

To align more Node.js Blob implementations with other runtimes (I've tested the behavior on Firefox, Safari, Chromium, and Deno).

Refs: https://webidl.spec.whatwg.org/#es-dictionary

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
buffer: fix validation of options in Blob constructor
138f0d7
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 25, 2022
@aduh95
fixup! buffer: fix validation of options in Blob constructor
cfa1ef0
@KhafraDev

KhafraDev commented Oct 25, 2022

Copy link
Copy Markdown
Member

it might be worth linking to the webidl spec https://webidl.spec.whatwg.org/#es-dictionary (it also helps to understand which values are allowed)
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung reviewed Oct 25, 2022
View reviewed changes
Comment thread lib/internal/validators.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 requested a review from jasnell October 26, 2022 10:48
aduh95
aduh95 commented Oct 27, 2022
View reviewed changes
Comment thread lib/internal/validators.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/validators.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
add comment and link to the spec
e4dbc9e
aduh95
aduh95 commented Oct 27, 2022
View reviewed changes
Comment thread lib/internal/validators.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
update error message
96230ee
@aduh95 aduh95 added the review wanted PRs that need review. label Oct 29, 2022
anonrig
anonrig approved these changes Oct 31, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 31, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 31, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47586/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung reviewed Oct 31, 2022
View reviewed changes
Comment thread lib/internal/validators.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung approved these changes Oct 31, 2022
View reviewed changes
@aduh95 @joyeecheung
fixup! buffer: fix validation of options in Blob constructor
1ff33ff 
Co-authored-by: Joyee Cheung <[email protected]>
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 31, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 31, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47599/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47602/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47604/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit d6ee274 into nodejs:main Oct 31, 2022
@aduh95
aduh95 deleted the blob-constructor-options-validation branch October 31, 2022 23:47
@aduh95

aduh95 commented Oct 31, 2022

Copy link
Copy Markdown
Contributor Author

Landed in d6ee274
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 1, 2022
CI Reliability 2022-11-01 nodejs/reliability#417
Open
17 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@aduh95 @RafaelGSS
buffer: fix validation of options in Blob constructor
e04602d 
PR-URL: #45156
Refs: https://webidl.spec.whatwg.org/#es-dictionary
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
This was referenced Nov 2, 2022
CI Reliability 2022-11-02 nodejs/reliability#418
Open
CI Reliability 2022-11-05 nodejs/reliability#419
Open
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@aduh95 @RafaelGSS
buffer: fix validation of options in Blob constructor
3369120 
PR-URL: #45156
Refs: https://webidl.spec.whatwg.org/#es-dictionary
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
buffer: fix validation of options in Blob constructor
c895bd1 
PR-URL: #45156
Refs: https://webidl.spec.whatwg.org/#es-dictionary
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
buffer: fix validation of options in Blob constructor
345b847 
PR-URL: #45156
Refs: https://webidl.spec.whatwg.org/#es-dictionary
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KhafraDev KhafraDev KhafraDev left review comments
@anonrig anonrig anonrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@jasnell jasnell Awaiting requested review from jasnell

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. review wanted PRs that need review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @KhafraDev @nodejs-github-bot @anonrig @joyeecheung
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.