GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add more LTS update steps to the release guide by ruyadorno · Pull Request #45177 · nodejs/node

Conversation

@ruyadorno

@ruyadorno ruyadorno commented Oct 25, 2022

Copy link
Copy Markdown
Member

This changeset adds references to two steps required for promoting a release line to LTS:

  • Adding the new codename to nodejs-latest-linker repo
  • Adding codename info to the Release repo

cc @nodejs/releasers

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2022 •
edited by ruyadorno
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 25, 2022
@ruyadorno

ruyadorno commented Oct 25, 2022

Copy link
Copy Markdown
Member Author

Hopefully this now captures all the still-undocumented steps required for the LTS promotion 🙏
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS approved these changes Oct 25, 2022
View reviewed changes
Comment thread doc/contributing/releases.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno
ruyadorno force-pushed the add-more-lts-update-steps-to-release-guide branch from ffddac6 to d45c09c Compare October 25, 2022 17:09
richardlau
richardlau approved these changes Oct 25, 2022
View reviewed changes
@ruyadorno
doc: add more lts update steps to release guide
5d5fcf7 
This changeset adds references to two steps required for promoting a
release line to LTS:

- Adding the new codename to nodejs-latest-linker repo
- Adding codename info to the Release repo

Signed-off-by: Ruy Adorno <[email protected]>
@ruyadorno
ruyadorno force-pushed the add-more-lts-update-steps-to-release-guide branch from d45c09c to 5d5fcf7 Compare October 25, 2022 19:15
mhdawson
mhdawson approved these changes Oct 26, 2022
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anonrig
anonrig approved these changes Oct 27, 2022
View reviewed changes
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 27, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45177
✔  Done loading data for nodejs/node/pull/45177
----------------------------------- PR info ------------------------------------
Title      doc: add more LTS update steps to the release guide (#45177)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     ruyadorno:add-more-lts-update-steps-to-release-guide -> nodejs:main
Labels     doc
Commits    1
 - doc: add more lts update steps to release guide
Committers 1
 - Ruy Adorno 
PR-URL: https://github.com/nodejs/node/pull/45177
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Richard Lau 
Reviewed-By: Michael Dawson 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45177
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Richard Lau 
Reviewed-By: Michael Dawson 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 25 Oct 2022 17:02:45 GMT
   ✔  Approvals: 4
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45177#pullrequestreview-1155183837
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45177#pullrequestreview-1155196395
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/45177#pullrequestreview-1157200015
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45177#pullrequestreview-1158219837
   ✖  This PR needs to wait 3 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3337834149
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 27, 2022
@nodejs-github-bot
nodejs-github-bot merged commit e17e903 into nodejs:main Oct 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

Landed in e17e903
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@ruyadorno @RafaelGSS
doc: add more lts update steps to release guide
500c15b 
This changeset adds references to two steps required for promoting a
release line to LTS:

- Adding the new codename to nodejs-latest-linker repo
- Adding codename info to the Release repo

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45177
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@ruyadorno @RafaelGSS
doc: add more lts update steps to release guide
58bec56 
This changeset adds references to two steps required for promoting a
release line to LTS:

- Adding the new codename to nodejs-latest-linker repo
- Adding codename info to the Release repo

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45177
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@ruyadorno @danielleadams
doc: add more lts update steps to release guide
9fb51a2 
This changeset adds references to two steps required for promoting a
release line to LTS:

- Adding the new codename to nodejs-latest-linker repo
- Adding codename info to the Release repo

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45177
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@ruyadorno @danielleadams
doc: add more lts update steps to release guide
3381a17 
This changeset adds references to two steps required for promoting a
release line to LTS:

- Adding the new codename to nodejs-latest-linker repo
- Adding codename info to the Release repo

Signed-off-by: Ruy Adorno <[email protected]>
PR-URL: #45177
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ruyadorno @nodejs-github-bot @anonrig @richardlau @mhdawson @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.