GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: add GitHub token to auto-start-ci workflow by richardlau · Pull Request #45185 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Oct 25, 2022

Copy link
Copy Markdown
Member

Recent changes to node-core-utils attempt to read pull request labels when deciding whether or not to start a V8 CI. This requires a valid GitHub token with appropriate permissions to be set for node-core-utils.

Fixes: #45163
Refs: nodejs/node-core-utils#652

Untested -- change based on

node/.github/workflows/commit-queue.yml

Line 80 in efd3c9c

ncu-config set token "${{ secrets.GH_USER_TOKEN }}"
. I think secrets.JENKINS_USER and secrets.GH_USER_NAME are the same (since we use GitHub auth in our Jenkins server).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau
build: add GitHub token to auto-start-ci workflow
cf30104 
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 25, 2022
@richardlau richardlau mentioned this pull request Oct 25, 2022
action lack permission to get pr info #45163
Closed
gengjiawen
gengjiawen approved these changes Oct 25, 2022
View reviewed changes
Trott
Trott approved these changes Oct 26, 2022
View reviewed changes
@gengjiawen gengjiawen added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 26, 2022
@github-actions

github-actions Bot commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.
gengjiawen and MoLow reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Oct 26, 2022
View reviewed changes
@gengjiawen gengjiawen added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 5e2aeae into nodejs:main Oct 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Landed in 5e2aeae
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau
richardlau deleted the startciperms branch October 26, 2022 17:17
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@richardlau @RafaelGSS
build: add GitHub token to auto-start-ci workflow
f1eca98 
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@richardlau @RafaelGSS
build: add GitHub token to auto-start-ci workflow
3a1ee94 
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@richardlau @danielleadams
build: add GitHub token to auto-start-ci workflow
7d9f699 
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@richardlau @danielleadams
build: add GitHub token to auto-start-ci workflow
3fb44f9 
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: nodejs/node-core-utils#652
PR-URL: #45185
Fixes: #45163
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

action lack permission to get pr info

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@richardlau @nodejs-github-bot @Trott @targos @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.