GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: fix icu-small build on mac with ICU 72.1 by srl295 · Pull Request #45195 · nodejs/node

Conversation

@srl295

@srl295 srl295 commented Oct 26, 2022 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • RTTI is needed for genrb now

Fixes: #45174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@srl295
srl295 requested review from aduh95, richardlau and targos October 26, 2022 19:58
@srl295 srl295 self-assigned this Oct 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to Node.js internationalization support. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 26, 2022
@srl295 srl295 mentioned this pull request Oct 26, 2022
Small ICU fails to build #45174
Closed
@srl295
build: fix icu-small build on mac with ICU 72.1
8d832f9 
- RTTI is needed for genrb now

Fixes: nodejs#45174
@srl295
srl295 force-pushed the srl295/issue45174 branch from 7ed430c to 8d832f9 Compare October 26, 2022 20:01
Trott
Trott approved these changes Oct 26, 2022
View reviewed changes
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2022
@richardlau

richardlau commented Oct 26, 2022

Copy link
Copy Markdown
Member

I don't have a mac to test this on but I can check on Linux tomorrow. I'd like to get nodejs/build#2998 set up but that doesn't need to block this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295

srl295 commented Oct 26, 2022

Copy link
Copy Markdown
Member Author

I don't have a mac to test this on but I can check on Linux tomorrow. I'd like to get nodejs/build#2998 set up but that doesn't need to block this.

yeah, the problem might not repro if not on a mac.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Oct 26, 2022
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that I'm able to build on this branch and with icu-small on macOS 12.6.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 26, 2022
@github-actions

github-actions Bot commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.
srl295, anonrig, and lpinca reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2022
gengjiawen
gengjiawen approved these changes Oct 27, 2022
View reviewed changes
anonrig
anonrig approved these changes Oct 27, 2022
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
lpinca
lpinca approved these changes Oct 27, 2022
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
richardlau
richardlau approved these changes Oct 27, 2022
View reviewed changes
@richardlau

richardlau commented Oct 27, 2022

Copy link
Copy Markdown
Member

FTR #45174 reproduces in RHEL 8 x64 with configure --with-intl=small-icu and I can confirm this PR fixes it there as well (so this is not a mac-specific issue).
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295

srl295 commented Oct 27, 2022 via email

Copy link
Copy Markdown
Member Author
Ok. Anyone feel free to land this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47502/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295

srl295 commented Oct 27, 2022

Copy link
Copy Markdown
Member Author

Is this ready to land?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 8fdac20 into nodejs:main Oct 27, 2022
@aduh95

aduh95 commented Oct 27, 2022

Copy link
Copy Markdown
Contributor

Landed in 8fdac20, thanks!
srl295 reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295

srl295 commented Oct 27, 2022

Copy link
Copy Markdown
Member Author

@aduh95 you got it. thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srl295
srl295 deleted the srl295/issue45174 branch October 27, 2022 19:24
This was referenced Oct 28, 2022
CI Reliability 2022-10-28 nodejs/reliability#413
Open
CI Reliability 2022-10-29 nodejs/reliability#414
Open
CI Reliability 2022-10-30 nodejs/reliability#415
Open
CI Reliability 2022-10-31 nodejs/reliability#416
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@srl295 @RafaelGSS
build: fix icu-small build with ICU 72.1
ba59911 
- RTTI is needed for genrb now.

Fixes: #45174
PR-URL: #45195
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@srl295 @RafaelGSS
build: fix icu-small build with ICU 72.1
f598edb 
- RTTI is needed for genrb now.

Fixes: #45174
PR-URL: #45195
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@srl295 @danielleadams
build: fix icu-small build with ICU 72.1
0b21ae2 
- RTTI is needed for genrb now.

Fixes: #45174
PR-URL: #45195
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@srl295 @danielleadams
build: fix icu-small build with ICU 72.1
abcc034 
- RTTI is needed for genrb now.

Fixes: #45174
PR-URL: #45195
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes
@targos targos Awaiting requested review from targos

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@srl295 srl295

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. i18n-api Issues and PRs related to Node.js internationalization support. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Small ICU fails to build

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@srl295 @nodejs-github-bot @richardlau @aduh95 @Trott @lpinca @anonrig @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.