GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: change make lint to make lint-md by RafaelGSS · Pull Request #45197 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 27, 2022

Copy link
Copy Markdown
Member

This change might save some time during the release steps.

cc: @nodejs/releasers

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@RafaelGSS
doc: change make lint to make lint-md
202417d 
This change might save some time during the release steps
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 27, 2022
juanarbol
juanarbol reviewed Oct 27, 2022
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why skip js linter but no cc linter?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos

targos commented Oct 27, 2022

Copy link
Copy Markdown
Member

@juanarbol The release commit contains changes to the documentation (md) and src/node_version.h (cc)
aduh95 and juanarbol reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Oct 27, 2022
View reviewed changes
aduh95
aduh95 approved these changes Oct 27, 2022
View reviewed changes
Trott
Trott approved these changes Oct 27, 2022
View reviewed changes
ruyadorno
ruyadorno approved these changes Oct 27, 2022
View reviewed changes
mhdawson
mhdawson approved these changes Oct 27, 2022
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
juanarbol
juanarbol approved these changes Oct 27, 2022
View reviewed changes

@juanarbol juanarbol left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
RafaelGSS added a commit that referenced this pull request Oct 27, 2022
@RafaelGSS
doc: change make lint to make lint-md
67edd72 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@RafaelGSS

RafaelGSS commented Oct 27, 2022

Copy link
Copy Markdown
Member Author

Landed in 67edd72
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS closed this Oct 27, 2022
RafaelGSS added a commit that referenced this pull request Nov 1, 2022
@RafaelGSS
doc: change make lint to make lint-md
9f546f0 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS added a commit that referenced this pull request Nov 10, 2022
@RafaelGSS
doc: change make lint to make lint-md
c179c14 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@RafaelGSS @danielleadams
doc: change make lint to make lint-md
4f768d2 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@RafaelGSS @danielleadams
doc: change make lint to make lint-md
4e87c36 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes
@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes
@juanarbol juanarbol juanarbol approved these changes
+2 more reviewers
@targos targos targos approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@RafaelGSS @nodejs-github-bot @targos @ruyadorno @Trott @mhdawson @aduh95 @juanarbol
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.