GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: workaround for node-core-utils by gengjiawen · Pull Request #45199 · nodejs/node

Conversation

@gengjiawen

@gengjiawen gengjiawen commented Oct 27, 2022

Copy link
Copy Markdown
Member

context: nodejs/node-core-utils#653 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@gengjiawen
gengjiawen requested a review from aduh95 October 27, 2022 03:34
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 27, 2022
@gengjiawen gengjiawen added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 27, 2022
@github-actions

github-actions Bot commented Oct 27, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.
aduh95, gengjiawen, anonrig, and legendecas reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Oct 27, 2022
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the value of NODE_VERSION instead? Otherwise it's pretty confusing:

node/.github/workflows/auto-start-ci.yml

Lines 13 to 14 in 5e2aeae

env:
NODE_VERSION: lts/*

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gengjiawen
build: workaround for node-core-utils
cf6bc87
@gengjiawen
gengjiawen force-pushed the fix/node_fetch_fix branch from 637cb28 to cf6bc87 Compare October 27, 2022 03:38
aduh95
aduh95 approved these changes Oct 27, 2022
View reviewed changes
richardlau
richardlau approved these changes Oct 27, 2022
View reviewed changes
@gengjiawen gengjiawen added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 27, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45199
✔  Done loading data for nodejs/node/pull/45199
----------------------------------- PR info ------------------------------------
Title      build: workaround for node-core-utils (#45199)
Author     Jiawen Geng  (@gengjiawen)
Branch     gengjiawen:fix/node_fetch_fix -> nodejs:main
Labels     meta, fast-track
Commits    1
 - build: workaround for node-core-utils
Committers 1
 - Jiawen Geng 
PR-URL: https://github.com/nodejs/node/pull/45199
Reviewed-By: Antoine du Hamel 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45199
Reviewed-By: Antoine du Hamel 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 27 Oct 2022 03:34:38 GMT
   ✔  Approvals: 2
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45199#pullrequestreview-1157558430
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45199#pullrequestreview-1158015502
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3336617372
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen gengjiawen removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 27, 2022
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 27, 2022
@aduh95

aduh95 commented Oct 27, 2022

Copy link
Copy Markdown
Contributor

I wonder if a better workaround would be to set NODE_OPTIONS to --dns-result-order=ipv4first since that seems to be what's the causing the issue according to the linked issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Oct 27, 2022
View reviewed changes
juanarbol
juanarbol approved these changes Oct 27, 2022
View reviewed changes
@gengjiawen gengjiawen added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 28, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 28, 2022
@nodejs-github-bot
nodejs-github-bot merged commit b2a6083 into nodejs:main Oct 28, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2022

Copy link
Copy Markdown
Collaborator

Landed in b2a6083
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 28, 2022
@gengjiawen
gengjiawen deleted the fix/node_fetch_fix branch October 28, 2022 01:15
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@gengjiawen @RafaelGSS
build: workaround for node-core-utils
ca73a24 
PR-URL: #45199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@gengjiawen @RafaelGSS
build: workaround for node-core-utils
75e0a2d 
PR-URL: #45199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@gengjiawen @danielleadams
build: workaround for node-core-utils
aa5c4e4 
PR-URL: #45199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@gengjiawen @danielleadams
build: workaround for node-core-utils
473a879 
PR-URL: #45199
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@gengjiawen @nodejs-github-bot @aduh95 @anonrig @richardlau @juanarbol
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.